641037 - Validation fails with KeyError: 'path'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: test file

steps to reproduce:
1. Upload the attached test file

traceback:
"Traceback (most recent call last): 
  File "/data/amo_python/www/preview/zamboni/apps/devhub/tasks.py", line 27, in validator 
    result = _validator(upload.path) 
  File "/data/amo_python/www/preview/zamboni/apps/devhub/tasks.py", line 70, in _validator 
    spidermonkey=settings.SPIDERMONKEY) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/validate.py", line 37, in validate 
    validator.submain.prepare_package(bundle, path, expectation) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/submain.py", line 53, in prepare_package 
    output = test_package(err, package, path, expectation) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/submain.py", line 139, in test_package 
    return test_inner_package(err, package_contents, package) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/submain.py", line 227, in test_inner_package 
    test_func(err, package_contents, xpi_package) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/testcases/l10ncompleteness.py", line 180, in test_xpi 
    ref_name.startswith(split_target[0])) 
  File "/data/amo_python/www/preview/zamboni/vendor/src/amo-validator/validator/testcases/l10ncompleteness.py", line 420, in _aggregate_results 
  (locale["path"], 
KeyError: 'path'

Comment 1

[Wil Clouser [:clouserw]]

Since it's a crash, let's get it into this release.  -> Basta

Comment 2

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/pull/6

Comment 3

[Matt Basta [:basta]]

Oops, wrong link:

https://github.com/mozilla/amo-validator/pull/7

Comment 4

[krupa raj[:krupa]]

verified fixed @ https://addons.allizom.org/en-US/developers/upload/9129418f5f044be7a5172640ff6c0864