641107 - warn users when libraries have conflicting module names

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Sean McArthur [:seanmonstar]]

For now, while the SDK conflicts with modules of the same name regardless of the package, we should warn users about this issue.

Make a Request getting all packages and modules associated with the currently editing package. Check for collisions for each case:

1) a new library is added
2) a library is updated to a new revision
3) a module is created
4) a module is renamed

Comment 1

[Piotr Zalewa [:zalun]]

System is now responding with conflicting modules
https://github.com/mozilla/FlightDeck/commit/7288924cc6773179fc632f62caabcdd8d6de9e42

Comment 2

[Sean McArthur [:seanmonstar]]

I can get the module lists and conflicted lists easily enough. What did we say should happen? Just a red roar?

Should it reveal a separate roar for each conflicting module? Or should the roar contain all the modules that are conflicts?

Comment 3

[Daniel Buchner [:dbuc]]

One Roar listing the various conflicting modules. I almost have a work-up of the new messaging system, so we can get more advanced with UI next release ;)

Comment 4

[Sean McArthur [:seanmonstar]]

Attachment: example of conflict modules

OK, then i'll doing something like this from the attachment

Comment 5

[Sean McArthur [:seanmonstar]]

in master https://github.com/mozilla/FlightDeck/commit/00fc0a3ff41ab3ce018c30d59c068bae3ce2d206