Closed Bug 641175 Opened 9 years ago Closed 9 years ago
Protect timer in browser
_tabview _bug599626 .js from being eaten by GC
Per http://www.joshmatthews.net/blog/2011/03/nsitimer-anti-pattern/, if we make it through the delay in http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/tabview/browser_tabview_bug599626.js#122 without doing GC, then the timer fires, but if we GC there's nothing to keep it alive, so it gets eaten, never fires, and the test times out.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #519072 - Flags: review?(ian)
Comment on attachment 519072 [details] [diff] [review] v1 Looks good.
Attachment #519072 - Flags: review?(ian) → review+
Attachment #519072 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox4.2
You need to log in before you can comment on or make changes to this bug.