If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Protect timer in browser_tabview_bug599626.js from being eaten by GC

RESOLVED FIXED in Firefox 5

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: philor, Assigned: raymondlee)

Tracking

Trunk
Firefox 5

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Per http://www.joshmatthews.net/blog/2011/03/nsitimer-anti-pattern/, if we make it through the delay in http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/tabview/browser_tabview_bug599626.js#122 without doing GC, then the timer fires, but if we GC there's nothing to keep it alive, so it gets eaten, never fires, and the test times out.
(Assignee)

Comment 1

7 years ago
Created attachment 519072 [details] [diff] [review]
v1
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #519072 - Flags: review?(ian)
Comment on attachment 519072 [details] [diff] [review]
v1

Looks good.
Attachment #519072 - Flags: review?(ian) → review+
(Assignee)

Comment 3

7 years ago
Created attachment 519309 [details] [diff] [review]
Patch for check-in

Passed try
http://tbpl.mozilla.org/?tree=MozillaTry&rev=2e547e7c7665
Attachment #519072 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed

Updated

7 years ago
Blocks: 640629
http://hg.mozilla.org/mozilla-central/rev/3a536f964865
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox4.2

Updated

7 years ago
Target Milestone: Firefox5 → Firefox 5
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.