Closed
Bug 641175
Opened 13 years ago
Closed 13 years ago
Protect timer in browser_tabview_bug599626.js from being eaten by GC
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 5
People
(Reporter: philor, Assigned: raymondlee)
References
Details
Attachments
(1 file, 1 obsolete file)
1.62 KB,
patch
|
Details | Diff | Splinter Review |
Per http://www.joshmatthews.net/blog/2011/03/nsitimer-anti-pattern/, if we make it through the delay in http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/tabview/browser_tabview_bug599626.js#122 without doing GC, then the timer fires, but if we GC there's nothing to keep it alive, so it gets eaten, never fires, and the test times out.
Assignee | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Comment on attachment 519072 [details] [diff] [review] v1 Looks good.
Attachment #519072 -
Flags: review?(ian) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Passed try http://tbpl.mozilla.org/?tree=MozillaTry&rev=2e547e7c7665
Attachment #519072 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Blocks: nsITimer-fail
http://hg.mozilla.org/mozilla-central/rev/3a536f964865
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox4.2
Updated•13 years ago
|
Target Milestone: Firefox5 → Firefox 5
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•