Closed Bug 641175 Opened 9 years ago Closed 9 years ago

Protect timer in browser_tabview_bug599626.js from being eaten by GC

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 5

People

(Reporter: philor, Assigned: raymondlee)

References

Details

Attachments

(1 file, 1 obsolete file)

Per http://www.joshmatthews.net/blog/2011/03/nsitimer-anti-pattern/, if we make it through the delay in http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/tabview/browser_tabview_bug599626.js#122 without doing GC, then the timer fires, but if we GC there's nothing to keep it alive, so it gets eaten, never fires, and the test times out.
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #519072 - Flags: review?(ian)
Comment on attachment 519072 [details] [diff] [review]
v1

Looks good.
Attachment #519072 - Flags: review?(ian) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/3a536f964865
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox4.2
Target Milestone: Firefox5 → Firefox 5
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.