641184 - try server "build" builders only generate try-comm-central revision info, but no mozilla-central repo info

Status: RESOLVED FIXED

(Mozilla Messaging Graveyard :: Try Server, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

For example, if you use the momo TBPL on a try build, for the "B" build you see:
using revision: try-comm-central/1f65f56ca518

But if we click on an "X" build, we see:
using revisions: try-comm-central/1f65f56ca518, mozilla-central/d8fe8514d7e6

This is problematic for arbitrarypushlog which expects all comm-central-style tinderbox trees to have both a comm-central-ish and mozilla-central-ish repo referenced.  Right now it ignores the "build" operations because of this.

(A related thing is that if we want arbitrarypushlog to be able to know what is happening with pending builds, it needs to be able to get this information for those builds too.  Ideally this info would come on a silver platter, but it should also be possible to scrape an early stage buildbot log if needed.)

Comment 1

[Philippe M. Chiasson (:gozer)]

Fixed. you'll see the correct revision displayed now.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

There are two-slashes in the URL:
ex: "mozilla-central//d8fe8514d7e6" instead of "mozilla-central/d8fe8514d7e6"

Comment 3

[Philippe M. Chiasson (:gozer)]

Should be fixed now.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

jhopkins' changes to the try server for bug 646219 appears to somehow have undone these changes... since the diff he provided on that bug does not seem to imply this result, maybe you can shed some light?

Comment 5

[Philippe M. Chiasson (:gozer)]

Re-Fixed, something was adding an extra slash, now defunct.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

it's generating double-slashes again.  re-opening here for context, although I'm also just going to put a work-around in the ArbPL code since it seems like it's hard to keep this from regressing...

Comment 7

[Philippe M. Chiasson (:gozer)]

Really? I am looking at http://tinderbox.mozilla.org/ThunderbirdTry/ I only see single slashes URLs. Like these:

http://hg.mozilla.org/try-comm-central/rev/71e6f783ceef
http://hg.mozilla.org/mozilla-central/rev/2c977d6f8a75

Could this be limited to a certain type of build/platform ? If you could show me a link to these broken builds, I could look at it.

@jhopkins, could this have been regressed by that last bbcustom try merge you performed ?

Comment 8

[Mark Banner (:standard8)]

You need to select a build on http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry and then you'll see the double slashes.

It may have happened when I swapped try server back from building mozilla-aurora to mozilla-central.

Comment 9

[Philippe M. Chiasson (:gozer)]

changeset:   1536:e9cb70677304
branch:      buildbot-0.8.0
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Tue May 17 16:04:08 2011 -0400
summary:     Bug 641184 - Generate hg.m.o links without '//'s

Comment 10

[John Hopkins (:jhopkins)]

gozer's patch applied to try.  New builds should not result in duplicate slashes.

Comment 11

[John Hopkins (:jhopkins)]

Verified that new builds do not exhibit the problem