Turn on -MD on mingw by default

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 518950 [details] [diff] [review]
fix v1.0

I don't know why the check for OS was added here in the first place:

  [dnl Default is to turn on -MD if using GNU-compatible compilers
  if test "$GNU_CC" -a "$GNU_CXX" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "WINCE"; then

All the OS_ARCH check does here is filtering out mingw, for which I don't see any reason. It works fine for me and helps a lot in fixing builds without --disable-ipc on mingw.
Attachment #518950 - Flags: review?(khuey)
Attachment #518950 - Flags: review?(khuey)
Attachment #518950 - Flags: review+
(Assignee)

Comment 1

7 years ago
Thanks for the review, pushed to build-system:

http://hg.mozilla.org/projects/build-system/rev/60381b92efa6
Whiteboard: fixed-in-bs
Assignee: nobody → jacek
http://hg.mozilla.org/mozilla-central/rev/8bdec572101f
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.