Closed Bug 641221 Opened 9 years ago Closed 9 years ago

Turn on -MD on mingw by default

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jacek, Assigned: jacek)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
I don't know why the check for OS was added here in the first place:

  [dnl Default is to turn on -MD if using GNU-compatible compilers
  if test "$GNU_CC" -a "$GNU_CXX" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "WINCE"; then

All the OS_ARCH check does here is filtering out mingw, for which I don't see any reason. It works fine for me and helps a lot in fixing builds without --disable-ipc on mingw.
Attachment #518950 - Flags: review?(khuey)
Thanks for the review, pushed to build-system:

http://hg.mozilla.org/projects/build-system/rev/60381b92efa6
Whiteboard: fixed-in-bs
Assignee: nobody → jacek
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.