Closed
Bug 641221
Opened 13 years ago
Closed 13 years ago
Turn on -MD on mingw by default
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jacek, Assigned: jacek)
Details
(Whiteboard: fixed-in-bs)
Attachments
(1 file)
|
1.96 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
I don't know why the check for OS was added here in the first place: [dnl Default is to turn on -MD if using GNU-compatible compilers if test "$GNU_CC" -a "$GNU_CXX" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "WINCE"; then All the OS_ARCH check does here is filtering out mingw, for which I don't see any reason. It works fine for me and helps a lot in fixing builds without --disable-ipc on mingw.
Attachment #518950 -
Flags: review?(khuey)
Attachment #518950 -
Flags: review?(khuey)
Attachment #518950 -
Flags: review+
|
Assignee | |
Comment 1•13 years ago
|
||
Thanks for the review, pushed to build-system: http://hg.mozilla.org/projects/build-system/rev/60381b92efa6
Whiteboard: fixed-in-bs
|
||
Updated•13 years ago
|
Assignee: nobody → jacek
http://hg.mozilla.org/mozilla-central/rev/8bdec572101f
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•