641252 - Update help for redesigned Software Installation preferences

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[rsx11m]

Bug 606482 has made some substantial changes in the Edit > Preferences >
Advanced > Software Installation pane which need to be documented, and
bug 639968 will introduce further changes.

Tasks for this bug:
 - Restructure help content in cs_nav_prefs_advanced.xhtml to match the new
   layout per bug 606482 (bug 639968 would include an update on the new pref);
 - replace old "Manage Permissions" text with reference to the Data Manager.

Per bug 639968 comment #20, help changes aren't subject to the string freeze, but nevertheless it's desired to get this updated as soon as possible.

Comment 1

[rsx11m]

Documenting the new data manager itself is bug 599097, thus a reference from this page to it should suffice with any specifics regarding this pane.

Comment 2

[rsx11m]

The description of the Add-ons Manager introduced by bug 373457 may need some update as well, specifically for the "Recommended Add-ons" section after the layout change in the "Get Add-Ons" page. This could be a separate bug if it doesn't exist yet and needs to cover a broader scope.

Comment 3

[rsx11m]

Attachment: Proposed patch

This patch mainly reshuffles things to reflect the new order of options and removes any obsolete options. I've removed the description of the old dialog
for website permissions but couldn't add any link to the Data Manager as it's still waiting to be written.

As for the nesting of the lists, I've stopped at the third level given that it starts looking weird if you'd really copy the nesting of the preferences in an exact hierarchy. I think it's still obvious how they relate to each other.

I didn't touch the Add-on Manager part, the description from bug 639968 also remains unchanged as it still applies in the new context.

Comment 4

[rsx11m]

Attachment: Proposed patch (v2)

Sorry, I forgot that I wanted to move the general description of the Add-on Manager upfront before describing the Add-ons group.

Comment 5

[Ian Neal]

Comment on attachment 527820 [details] [diff] [review]
Proposed patch (v2)

>+++ b/suite/locales/en-US/chrome/common/help/cs_nav_prefs_advanced.xhtml	Fri Apr 22 13:40:55 2011 -0500
>+  <li><strong>Add-ons</strong>:
>     <ul>
>+      <li><strong>Allow websites to install extensions and updates</strong>:
Nit: it is "add-ons" rather than "extensions" now.

>+        Select this if you want to allow websites to install extensions and
Nit: and again.

r=me with that fixed.

Comment 6

[rsx11m]

Attachment: Final patch [Checkin: comment 10]

Thanks Ian.

(In reply to comment #5)
> >+      <li><strong>Allow websites to install extensions and updates</strong>:
> Nit: it is "add-ons" rather than "extensions" now.

Forgot to double-check the label when copy-pasting, both occurrences fixed.

Two more minor fixes applied in this patch:
 - I've changed "updated notifications" to just "updates" as they are now
   installing automatically if so selected (thus, no longer just notify);
 - "Add-on Manager" is now actually "Add-ons Manager", I've corrected that
   and will file follow-up bugs for any UI and help changes as necessary.

Comment 7

[rsx11m]

Push for comm-central, please. This is Help content only, thus requesting approval for comm-2.0 in parallel.

The spin-off bugs are bug 652327 and bug 652328.

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 527942 [details] [diff] [review]
Final patch [Checkin: comment 10]

comm-2.0 is open, and help is not affected by l10n freeze

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #6)
>  - "Add-on Manager" is now actually "Add-ons Manager", I've corrected that
>    and will file follow-up bugs for any UI and help changes as necessary.

This change is only valid for the trunk, so whoever pushes this to branch needs to change it back or require a separate patch. Alternate approach: Change it back completely and leave the actual change to bug 652328.

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 527942 [details] [diff] [review]
Final patch [Checkin: comment 10]

http://hg.mozilla.org/comm-central/rev/52c2ccceb1d7
http://hg.mozilla.org/releases/comm-2.0/rev/41ebfb00ca65

Same for both: Reverted to "Add-on Manager" since I think this is better to be handled in its own bug, and you didn't request review for that change.

Dropping approval since none is needed.

Comment 11

[rsx11m]

> (comment #9) This change is only valid for the trunk,

Actually, for Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.2pre) Gecko/20110423 SeaMonkey/2.1pre, both the window decoration and the tab titles show the plural for "Add-ons Manager" as well, thus I figured it's the same for both. 

> (comment #10) Reverted to "Add-on Manager" since I think this is better to be
> handled in its own bug, and you didn't request review for that change.

Agreed, I'm fine with deferring this to bug 652328 to have it in a single bug. Sorry for exceeding what's acceptable in changes after a review approval...

Thanks for getting this in!

Comment 12

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #11)
> > (comment #9) This change is only valid for the trunk,
> 
> Actually, for Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.2pre) Gecko/20110423
> SeaMonkey/2.1pre, both the window decoration and the tab titles show the plural
> for "Add-ons Manager" as well, thus I figured it's the same for both. 

Oh, my bad then. I should have checked myself. It seems the change goes at least all the way back to bug 554007 which landed 2010-04-29. Anyway, as I said, better in its own bug.