If file already open in Composer, browser's Open location in new composer window does not find it

VERIFIED FIXED in mozilla0.8

Status

()

VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: sfraser_bugs, Assigned: cmanske)

Tracking

Trunk
mozilla0.8
All
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
Normally in Composer, opening a file which is already open for editing just 
brings the relevant window to the front, to avoid opening the file twice.

However, this does not work if, when the file is already open in Composer, you 
use the 'Open location dialog' in the browser window (and pick open in new 
composer window). We need to go through the logic to look for an open window with 
that file in this case also.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.8
(Assignee)

Comment 1

18 years ago
Created attachment 22475 [details] [diff] [review]
XPFE fix for the bug
(Reporter)

Comment 2

18 years ago
sr=sfraser
(Assignee)

Comment 3

18 years ago
All non-editor windows that want to create an editor with a particular url should
now use "editPage()" method in utilityOverlay.js. It will search for
Opening an editor via File | Edit Page, File | Open Location, and "Edit Link" on
the context menu now use editPage().
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 4

18 years ago
Reopening, this broke Edit Page and Edit Link in Composer in navigator.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 5

18 years ago
JavaScript error:
chrome://communicator/content/utilityOverlay.js line 441: launchWindow has no pr
operties

Maybe you need to update the calls from nsContextMenu.js and 
navigatorOverlay.xul?  Although you have that launchWindow check.
(Assignee)

Comment 6

18 years ago
This seems to be an unrelated problem in
nsEditorShell.cpp::CheckOpenWindowForURLMatch(), which changed recently.
It's chocking when one of the editors hasn't saved to file yet.
Sorry, I realize my testing always used existing files, given the nature of the
bug, that made sense!
It makes better sense to open a new bug for this.

Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

18 years ago
Note that problem found here is now bug 65610

Comment 8

18 years ago
Hmm...really? I can't imagine this not being a problem with the fix, given the 
launchWindow JS error...

Comment 9

18 years ago
verified in 1/30 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.