Closed Bug 641300 Opened 13 years ago Closed 13 years ago

Session restore also restores popup windows

Categories

(Firefox :: Session Restore, defect)

x86
Linux
defect
Not set
major

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: samul, Unassigned)

Details

User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0

Since ff4 session restore also seems to restore popup windows. I use the delicious bookmarklet to save webpages to delicious. This bookmarklet opens a popup window. After submitting the page, the window gets closed. Now, when I restart ff4, all several delicious windows (and other popup windows) are restored too.

Reproducible: Always

Steps to Reproduce:
1. Use the delicious bookmarklet
2. submit a page
3. restart ff4
Actual Results:  
Popup windows that were closed are restored. I then have to close several windows.

Expected Results:  
No windows that were closed during the previous session should be restored.

I have noscript plugin installed. I only mention this because the delicious bookmarklet behaves slightly differently when run from a whitelisted page or when run from a page for which noscript disabled javascript.
Mozilla/5.0 (X11; Linux i686; rv:2.0b13pre) Gecko/20110314 Firefox/4.0b13pre

Tom, I am unable to reproduce the issue you have reported. After adding bookmarks using the Delicious bookmarklet, forcibly closing FF and restoring the last session, the pop-up windows are not shown.

Can you please try reproducing this issue with a clean profile:
http://support.mozilla.com/en-US/kb/Managing%20profiles
The problem doesn't occur every time. I haven't yet found out what triggers the problem. I am not able to reproduce this myself reliably. But every since I started using ff4, it happens from time to time that I see all those delicious windows when restoring a session. Maybe it has to do with how firefox was closed. I'll report back when I know more.
I don't know the code but could it make a difference whether ff4 is exited by closing the window or by exiting the gnome desktop? Right now, I logged out from gnome while ff4 was running. gnome closed ff4. I then logged in again and whoops, there was that delicious window again. Could it be the session info isn't properly updated?

I run ubuntu 10.04, gnome 2.30.2.
(In reply to comment #3)
> I don't know the code but could it make a difference whether ff4 is exited by
> closing the window or by exiting the gnome desktop? Right now, I logged out
> from gnome while ff4 was running. gnome closed ff4. I then logged in again and
> whoops, there was that delicious window again. Could it be the session info
> isn't properly updated?
> 
> I run ubuntu 10.04, gnome 2.30.2.

Can you reliably reproduce this by exiting Gnome with Firefox running (ie. reproducible every time you try)?
I apologize for the comment 3. That was magical thinking. I can reproduce it with my profile (no logout from gnome required) but not with a vanilla profile.
Alright, here's how we (session restore) handles popups:

- when quitting (via file > exit, killing process, shutting down gnome), all windows that are open will be reopened (that includes popups), unless of course we open about:sessionrestore from too many crashes

- when closing the window by window to quit, we always open the last window closed when starting up.

- we keep track of popups vs non-popups. we make sure that a non-popup will be reopened at startup, not just a popup

- when closing window-by-window, we'll reopen the last non-popup and any popups that are closed after it.

So my guess here is that you're closing window-by-window and closing the delicious popup (or series of) last. And that's why you can only sometimes reproduce this.
I'm not sure I understand this. The delicious popup window was already closed a long time before -- after submitting the page. When I close ff4, the main window is the only window visible.

Anyway, I will move to a new profile and hope this will make the problem go away.
(In reply to comment #7)
> I'm not sure I understand this. The delicious popup window was already closed a
> long time before -- after submitting the page. When I close ff4, the main
> window is the only window visible.

Ah, I missed that part of the report. Sorry. Possibly related to bug 642624...
Tom, it's possible that an add-on is triggering this problem based on comment 5.  Can you please provide a list of all installed add-ons and their versions?

Thanks.
It seems it was caused by a corrupted profile. I now switched to a new profile and haven't had that problem ever since. I think this issue can be closed.
Thanks Tom.  Marking RESOLVED.  If you see the issue again, please reopen this bug.
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.