641304 - Cannot find dictionaries via Add-ons Manager

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

FF 4.0 NB. I have a problem with finding czech spell dictionary via search in Add-ons Manager in FF 4.0. My keyword is "slovník" ("dictionary" in english).

On AMO I see czech spell dictionary on the first position:
https://addons.mozilla.org/cs/firefox/search/?q=slovn%C3%ADk&cat=all&x=0&y=0

When I try the same keyword via search in Add-ons Manager I don't see czech spell dictionary in search results.

Dictionary which I'm looking for:
https://addons.mozilla.org/cs/firefox/addon/czech-spell-checking-dictionar/

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The API is working fine and returns it as the first item:

https://addons.allizom.org/en-US/firefox/api/1.5/search/%C4%8Cesk%C3%A9%20slovn%C3%ADky%20pro%20kontrolu%20pravopisu/all/30/Darwin/4.0b12pre?src=firefox

But it removes the special characters in the name so it end-up as 'Czech spell checking dictionary' instead of 'České slovníky pro kontrolu pravopisu'.

In Firefox 3.6 I only see a result when I search for the modified string. So we have at least a regression here.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Pavel, would you have time to check for the regression range? I would really appreciate it.

Comment 3

[Pavel Cvrcek [:JasnaPaka]]

(In reply to comment #2)
> Pavel, would you have time to check for the regression range? I would really
> appreciate it.

Ok. I'm going to find regression range later today.

Comment 4

[Pavel Cvrcek [:JasnaPaka]]

I have tried to find regression range but it looks like I cannot find it.

2010-02-31 - ok (old Add-ons Manager)
2010-04-31 - cannot test
2010-06-31 - cannot test
2010-08-21 - fail

"cannot test" - this means that search function from AMO wasn't available in these builds. Not sure if it is helpful if I try to find some build between "cannot test" and "fail".

Can I help in some way with this bug? Looks like this bug is related to Add-ons Manager rewrite but maybe I'm wrong.

Comment 5

[juan becerra [:juanb]]

Do search results from the add-ons manager search field not match those you get from AMO?

Comment 6

[Pavel Cvrcek [:JasnaPaka]]

(In reply to comment #5)
> Do search results from the add-ons manager search field not match those you get
> from AMO?

I get total different results. I'm going to attach screenshots.

Comment 7

[Pavel Cvrcek [:JasnaPaka]]

Attachment: Results on AMO

This is ok. You can see "czech spellchecker" in the list.

Comment 8

[Pavel Cvrcek [:JasnaPaka]]

Attachment: Results inside Add-ons Manager (FF 4)

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

See my comment 1 for results we get back from AMO. It's clearly a fault of the AOM which strips out that search result.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #4)
> Can I help in some way with this bug? Looks like this bug is related to Add-ons
> Manager rewrite but maybe I'm wrong.

Thanks for having a check Pavel! It looks like we have to wait for a reply from Dave or Blair.

Comment 11

[Dave Townsend [:mossop]]

You can see the problem from the error console:

Warning: WARN addons.repository: Unknown type id when parsing addon: 3
Source File: resource://gre/modules/AddonRepository.jsm
Line: 899

The AMO API is returning dictionaries with type="3". Previously we assumed that anything that wasn't type="2" was an extension. Now we explicitly check for type 1 and 2 for extension and theme.

Comment 12

[Dave Townsend [:mossop]]

We should probably block a .x release on this regression.

Comment 13

[Julen Ruiz Aizpuru]

So this means users can't find the dictionaries listed at https://addons.mozilla.org/eu/firefox/language-tools/ right?

That's the behaviour I'm experiencing at least, and Basque users are reporting they can't find the dictionary for their locale (eu). In other "bigger" languages this might not be a problem, since there are multiple dictionaries available.

In our case though, we have a single dictionary available, and users end up thinking the dictionary doesn't exist or isn't compatible with newer versions of Firefox anymore.

What is needed for this to work? Handling the type="3" results[1] would be a start I think, but I don't know the internal details, so more stuff would be required, I guess.

[1] https://hg.mozilla.org/mozilla-central/file/f107192c7d59/toolkit/mozapps/extensions/AddonRepository.jsm#l929

Comment 14

[Dave Townsend [:mossop]]

Bug 591780 has the fix for this

Comment 15

[Jesper Kristensen]

Works in Mozilla/5.0 (Windows NT 6.0; rv:10.0a1) Gecko/20111008 Firefox/10.0a1