Closed
Bug 641304
Opened 13 years ago
Closed 13 years ago
Cannot find dictionaries via Add-ons Manager
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla10
Tracking | Status | |
---|---|---|
blocking2.0 | --- | .x+ |
People
(Reporter: JasnaPaka, Unassigned)
References
Details
(Keywords: regression, Whiteboard: [wanted fx5])
Attachments
(2 files)
FF 4.0 NB. I have a problem with finding czech spell dictionary via search in Add-ons Manager in FF 4.0. My keyword is "slovník" ("dictionary" in english). On AMO I see czech spell dictionary on the first position: https://addons.mozilla.org/cs/firefox/search/?q=slovn%C3%ADk&cat=all&x=0&y=0 When I try the same keyword via search in Add-ons Manager I don't see czech spell dictionary in search results. Dictionary which I'm looking for: https://addons.mozilla.org/cs/firefox/addon/czech-spell-checking-dictionar/
Comment 1•13 years ago
|
||
The API is working fine and returns it as the first item: https://addons.allizom.org/en-US/firefox/api/1.5/search/%C4%8Cesk%C3%A9%20slovn%C3%ADky%20pro%20kontrolu%20pravopisu/all/30/Darwin/4.0b12pre?src=firefox But it removes the special characters in the name so it end-up as 'Czech spell checking dictionary' instead of 'České slovníky pro kontrolu pravopisu'. In Firefox 3.6 I only see a result when I search for the modified string. So we have at least a regression here.
Keywords: regression,
regressionwindow-wanted
Version: unspecified → Trunk
Comment 2•13 years ago
|
||
Pavel, would you have time to check for the regression range? I would really appreciate it.
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to comment #2) > Pavel, would you have time to check for the regression range? I would really > appreciate it. Ok. I'm going to find regression range later today.
Reporter | ||
Comment 4•13 years ago
|
||
I have tried to find regression range but it looks like I cannot find it. 2010-02-31 - ok (old Add-ons Manager) 2010-04-31 - cannot test 2010-06-31 - cannot test 2010-08-21 - fail "cannot test" - this means that search function from AMO wasn't available in these builds. Not sure if it is helpful if I try to find some build between "cannot test" and "fail". Can I help in some way with this bug? Looks like this bug is related to Add-ons Manager rewrite but maybe I'm wrong.
Comment 5•13 years ago
|
||
Do search results from the add-ons manager search field not match those you get from AMO?
Reporter | ||
Comment 6•13 years ago
|
||
(In reply to comment #5) > Do search results from the add-ons manager search field not match those you get > from AMO? I get total different results. I'm going to attach screenshots.
Reporter | ||
Comment 7•13 years ago
|
||
This is ok. You can see "czech spellchecker" in the list.
Reporter | ||
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
See my comment 1 for results we get back from AMO. It's clearly a fault of the AOM which strips out that search result.
Comment 10•13 years ago
|
||
(In reply to comment #4) > Can I help in some way with this bug? Looks like this bug is related to Add-ons > Manager rewrite but maybe I'm wrong. Thanks for having a check Pavel! It looks like we have to wait for a reply from Dave or Blair.
Keywords: regressionwindow-wanted
Comment 11•13 years ago
|
||
You can see the problem from the error console: Warning: WARN addons.repository: Unknown type id when parsing addon: 3 Source File: resource://gre/modules/AddonRepository.jsm Line: 899 The AMO API is returning dictionaries with type="3". Previously we assumed that anything that wasn't type="2" was an extension. Now we explicitly check for type 1 and 2 for extension and theme.
Blocks: 551274
Summary: Cannot find czech dictionary via Add-ons Manager → Cannot find dictionaries via Add-ons Manager
Comment 12•13 years ago
|
||
We should probably block a .x release on this regression.
blocking2.0: --- → ?
Updated•13 years ago
|
blocking2.0: ? → .x+
Updated•13 years ago
|
Whiteboard: [wanted fx5]
Comment 13•13 years ago
|
||
So this means users can't find the dictionaries listed at https://addons.mozilla.org/eu/firefox/language-tools/ right? That's the behaviour I'm experiencing at least, and Basque users are reporting they can't find the dictionary for their locale (eu). In other "bigger" languages this might not be a problem, since there are multiple dictionaries available. In our case though, we have a single dictionary available, and users end up thinking the dictionary doesn't exist or isn't compatible with newer versions of Firefox anymore. What is needed for this to work? Handling the type="3" results[1] would be a start I think, but I don't know the internal details, so more stuff would be required, I guess. [1] https://hg.mozilla.org/mozilla-central/file/f107192c7d59/toolkit/mozapps/extensions/AddonRepository.jsm#l929
Comment 15•13 years ago
|
||
Works in Mozilla/5.0 (Windows NT 6.0; rv:10.0a1) Gecko/20111008 Firefox/10.0a1
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•