641460 - Fennec stays minimized when closing multiple tabs on Maemo /MeeGo

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jeremias Bosch (:jbos)]

Attachment: Disable Warn On Close for Meego / Maemo

In Meego Warning on Close prevent Fennec on MeeGo to close successfully which cause that Fennec can not be started a second time ("Firefox is already running"-Error)

This is because of this warning. We simply need to disable it.

Comment 1

[Oleg Romashin (:romaxa)]

Comment on attachment 519115 [details] [diff] [review]
Disable Warn On Close for Meego / Maemo

I don't think this is a good idea to to do it this way, fennec is single window multi-tab app, and when you close fennec from taskswitcher with multiple tabs we should bring fennec to the user and allow to choos close fennec or not.

Comment 2

[Jeremias Bosch (:jbos)]

Duno if this allowed in meego ui spec / possible.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 519115 [details] [diff] [review]
Disable Warn On Close for Meego / Maemo

I agree with Oleg. If you wanted to get fancy, you could just close the current tab when closing from the task switcher. As a baseline, you should do what Oleg suggests and focus fennec and display the shutdown prompt.

Comment 4

[Jeremias Bosch (:jbos)]

yep. i dont want to doubt that. The thing is that taskswitcher just remove the window (without waiting on action from application).

Mhm I need to investigate if there are option to do raise the window once more - but i'm sure its not fitting device rules.

Comment 5

[Jeremias Bosch (:jbos)]

Looks like the window get just killed, without requesting / waiting for the application. So even if we open the Window and ask for opinion of user the browser window will be gone from taskswitcher.

I do not see any option for asking the user / giving the user a choice to rethink his action.

Comment 6

[Jeremias Bosch (:jbos)]

Sorry for the spam.

How should we proceed now? Turn off the pref is the only option i see.

Comment 7

[Tatiana Meshkova (:tatiana)]

in order to prevent closing for graphics view we need something like 

    void closeEvent(QCloseEvent *event)
    {
        event->ignore();
        activateWindow();
    }

Comment 8

[Tatiana Meshkova (:tatiana)]

Attachment: Activate while waiting to close

Comment 9

[Oleg Romashin (:romaxa)]

Comment on attachment 529742 [details] [diff] [review]
Activate while waiting to close

>         this._waitingToClose = true;
>+#ifdef MOZ_PLATFORM_MAEMO
>+        window.QueryInterface(Ci.nsIDOMChromeWindow).restore();
>+#endif

I guess mobile-UI guys need to check this part

Comment 10

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/94042ef440fa

Comment 11

[Andreea Pod]

Can you provide some STR so we can verify this please?

Comment 12

[Oleg Romashin (:romaxa)]

I see it works fine now, but I'm not sure am I able to set verify status or not...