Closed Bug 641474 Opened 14 years ago Closed 14 years ago

[dashboard][webby] Add pending opt-ins count

Categories

(Mozilla Localizations :: Infrastructure, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

Details

Attachments

(2 files, 2 obsolete files)

We could use a view for pending opt-ins.
Assignee: nobody → gandalf
Attached patch patch, v1 (obsolete) — Splinter Review
Actually, after some brainstorm with Stas we decided not to use a separate view, instead adding a single column for staff members.
Attachment #519121 - Flags: review?(stas)
Comment on attachment 519121 [details] [diff] [review] patch, v1 I think a more future-proof solution would be to use groupby to reduce the number of queries. I'll attach a new patch in a sec.
Attachment #519121 - Flags: review?(stas) → review-
Attached patch Use groupbySplinter Review
Attachment #519121 - Attachment is obsolete: true
Attachment #519132 - Flags: review?(gandalf)
Comment on attachment 519132 [details] [diff] [review] Use groupby r+
Attachment #519132 - Flags: review?(gandalf) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reopening. Don't use is_staff for security, but explicit permissions instead.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Why is is_staff bad? If we are going to use permissions, should we use weeby.change_weblocale? Should the 'drivers' group get it?
is_staff relies on us granting permissions to do everything anywhere to anyone that needs to take opt-ins. Bad. webby.change_weblocale sounds OK as a permission, and we can start with adding that priv to drivers. Doesn't keep us from adding it to individual users, too.
Attached patch Check perms instead of is_staff (obsolete) — Splinter Review
Attachment #519167 - Flags: review?(gandalf)
extended stas's patch to cover all bases
Attachment #519167 - Attachment is obsolete: true
Attachment #519167 - Flags: review?(gandalf)
Attachment #519192 - Flags: review?(stas)
Comment on attachment 519192 [details] [diff] [review] Check perms instead of is_staff|is_authenticated Cool.
Attachment #519192 - Flags: review?(stas) → review+
fxd for now. We'll want to lean back from cronjob in a separate bug.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: