Closed
Bug 641474
Opened 14 years ago
Closed 14 years ago
[dashboard][webby] Add pending opt-ins count
Categories
(Mozilla Localizations :: Infrastructure, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
Details
Attachments
(2 files, 2 obsolete files)
2.54 KB,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
3.27 KB,
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
We could use a view for pending opt-ins.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → gandalf
Assignee | ||
Comment 1•14 years ago
|
||
Actually, after some brainstorm with Stas we decided not to use a separate view, instead adding a single column for staff members.
Attachment #519121 -
Flags: review?(stas)
Comment 2•14 years ago
|
||
Comment on attachment 519121 [details] [diff] [review]
patch, v1
I think a more future-proof solution would be to use groupby to reduce the number of queries. I'll attach a new patch in a sec.
Attachment #519121 -
Flags: review?(stas) → review-
Comment 3•14 years ago
|
||
Attachment #519121 -
Attachment is obsolete: true
Attachment #519132 -
Flags: review?(gandalf)
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 519132 [details] [diff] [review]
Use groupby
r+
Attachment #519132 -
Flags: review?(gandalf) → review+
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 6•14 years ago
|
||
Reopening. Don't use is_staff for security, but explicit permissions instead.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•14 years ago
|
||
Why is is_staff bad?
If we are going to use permissions, should we use weeby.change_weblocale? Should the 'drivers' group get it?
Comment 8•14 years ago
|
||
is_staff relies on us granting permissions to do everything anywhere to anyone that needs to take opt-ins. Bad.
webby.change_weblocale sounds OK as a permission, and we can start with adding that priv to drivers. Doesn't keep us from adding it to individual users, too.
Comment 9•14 years ago
|
||
Attachment #519167 -
Flags: review?(gandalf)
Assignee | ||
Comment 10•14 years ago
|
||
extended stas's patch to cover all bases
Attachment #519167 -
Attachment is obsolete: true
Attachment #519167 -
Flags: review?(gandalf)
Attachment #519192 -
Flags: review?(stas)
Comment 11•14 years ago
|
||
Comment on attachment 519192 [details] [diff] [review]
Check perms instead of is_staff|is_authenticated
Cool.
Attachment #519192 -
Flags: review?(stas) → review+
Assignee | ||
Comment 12•14 years ago
|
||
fxd for now. We'll want to lean back from cronjob in a separate bug.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•