Closed
Bug 641707
Opened 13 years ago
Closed 13 years ago
Broken browser-chrome tests due to portrait, closeTab and select UI changes
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(2 files)
15.92 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
5.20 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
In addition to some portrait/landscape cleanup, the patch also: * turns off browser_forms and browser_formsZoom since they fail badly * adds a todo in browser_awesomescreen that needs to be fixed * uses claseTab(aTab, { forceClose: true }) in browser_tabs since the tests assume sync closing * doesn't try to close any other tabs in browser_tabs * fixes some 800 pixel assumptions in browser_viewport * fixes tests broken by select UI changes
Attachment #519283 -
Flags: review?(mbrubeck)
Comment 1•13 years ago
|
||
This fixes some timeouts, and sets the stage for tests of bug 640997 (which will require both metadata *and* style).
Attachment #519285 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•13 years ago
|
Attachment #519285 -
Flags: review?(mark.finkle) → review+
Comment 2•13 years ago
|
||
Comment on attachment 519285 [details] [diff] [review] [checked in] clean up browser_viewport.js http://hg.mozilla.org/mobile-browser/rev/2cfaf94b72fe
Attachment #519285 -
Attachment description: clean up browser_viewport.js → [checked in] clean up browser_viewport.js
Updated•13 years ago
|
Attachment #519283 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 3•13 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/23a20e51b2d8 with these two patches, browser-chrome tests are all green on desktop linux
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•13 years ago
|
||
filed bug 641825 to get forms and formsZoom tests working again
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•