Closed Bug 641723 Opened 14 years ago Closed 14 years ago

Change browser.waitForPageLoad to use _controller

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gmealer, Unassigned)

References

Details

(Whiteboard: [module-refactor])

Attachments

(1 file)

Fixes the Browser class to use the private _controller field
669 bytes, patch
whimboo
: review+
Details | Diff | Splinter Review
When we removed the public controller getter, we forgot about the Browser object, which uses it. For now, patching to go to the internal _controller, but that's breaking encapsulation and I'm not fully comfortable with it.
Attachment #519306 - Flags: review?(hskupin) → review+
Lets investigate later how we can solve that better.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: