64176 - [tabbing] tabbing in prefs->advanced->proxies is messed up

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Jesse Ruderman]

Prefs->Advanced->Proxies

In Classic, if I tab from the second radio button in prefs->advanced->proxies, 
I *sometimes* land in the text field below it and sometimes end up in bug 64052 
limbo.

1. Click on "manual proxy configuration".
2. Tab. (end up in bug 64052 limbo.)
(repeat 1 and 2 a few times if you want)
3. Click on "manual proxy configuration".
4. Shift+tab. (end up in bug 64052 limbo.)
5. Click on "manual proxy configuration".
6. Tab. (end up where you want to be :). )
7. Click on "manual proxy configuration".
8. Tab. (end up in bug 64052 limbo.)

That seems kinda strange...

Cc blake from bug 56141, since this might be related.

Comment 1

[Peter Trudelle]

Classic, eh?  ->ben

Comment 2

[Keyser Sose]

Confirmed
Still occuring on
Platform: PC
OS: Windows 98
Mozilla Build: 2001022311

Working on most doomed which happens to be Ben right now.

Comment 3

[Jesse Ruderman]

Raising severity back to normal: this prevents keyboard-only users from using 
the panel, and annoys other users who like to use tab to get between text 
fields instead of reaching for the mouse.

Comment 4

[Paul Chen]

Marking nsbeta1+, polish, mozilla0.9, reassigning to pchen

Comment 5

[Paul Chen]

Marking p3

Comment 6

[Blake Ross]

Taking this, if pchen doesn't mind...

Comment 7

[Blake Ross]

Is the situation improved at all by bryner's patch?

Comment 8

[Blake Ross]

Renominating for beta1, this isn't critical.

Comment 9

[Blake Ross]

jag and bryner have been stuck in focus hell for days, I just KNOW that one of 
them wants this bug really badly...

starting with bryner because he's not around yet to kick my ass ;)

Comment 10

[Brian Ryner (not reading)]

sigh, i have too many of these focus bugs piling up

Comment 11

[Brian Ryner (not reading)]

The problem here is that we do a depth-first traversal of the frame tree for
each tabindex.  So, when the "Manual proxy configuration" radio item is focused,
it's assumed that we have already traversed all of its children, so the next tab
pops "out".  The fact that you can trick it out by shift-tabbing, clicking, and
tabbing is a separate bug.

Possible solutions:

- Change the frame traversal method so that we hit parents before their children.

- Put explicit tabindex= attributes on the text fields.

Comment 12

[Brian Ryner (not reading)]

saari and I decided to go with option #1.  Patch coming up.

Comment 13

[Brian Ryner (not reading)]

Attachment: patch

Comment 14

[David Hyatt]

sr=hyatt

Comment 15

[saari (gone)]

r=saari

Comment 16

[Brian Ryner (not reading)]

checked in.