Closed Bug 641781 Opened 10 years ago Closed 10 years ago
Port the safe mode startup screen from Firefox to Thunderbird
We'd like to port the safe mode start-up screen from Firefox to Thunderbird (see attached screenshot from Firefox). I've spoken to Bryan and we think that "Disable all add-ons" and "Reset toolbars and controls" are the two options that we can keep. This will form part of work to improve our safe mode set-up to follow suit with what Firefox has done.
Attachment #519366 - Attachment mime type: application/octet-stream → image/png
Pretty much a straight port of the Firefox window, modulo the actual startup switches. sr because of the mail glue stuff -- I couldn't really think of a better way to do this.
This is what it looks like in action.
Comment on attachment 520740 [details] [diff] [review] patch v1 reviewing based on the screenshot in attachment 520741 [details] and it looks great.
Attachment #520740 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 520740 [details] [diff] [review] patch v1 Full review at the review dashboard: http://reviews.visophyte.org/r/520740/ These days the superreviewer can't be the same as the reviewer, although I think that copying what FF did for browserGlue is just right and will mean at least the idea is well tested already. on file: mail/base/content/safeMode.xul line 55 > buttonlabelaccept="&changeAndRestartButton.label;" > #ifdef XP_WIN > buttonlabelcancel="&quitApplicationCmd.label;" > #else > buttonlabelcancel="&quitApplicationCmdUnix.label;" > #endif > buttonlabelextra1="&continueButton.label;" I'm a bit surprised that there's no accesskeys here. Please check that all the buttons are accessible on Windows at least. on file: mail/base/content/safeMode.xul line 79 > <checkbox id="disableAddons" label="&disableAddons.label;" accesskey="&disableAddons.accesskey;"/> nit: only one space between attributes. You might also want to consider wrapping as these are getting a bit long.
Attachment #520740 - Flags: superreview?(bienvenu) → superreview+
https://hg.mozilla.org/comm-central/rev/765eb39e92ea I added accesskeys and removed the extra spaces. I didn't feel they were long enough to warrant breaking them up into multiple lines. (This caused builds on all platforms to go red, but a clobber fixed everything)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
Forgot to add mailGlue.js to package-manifest.in. Pushed the fix as a followup: https://hg.mozilla.org/comm-central/rev/61e3bd69a9eb. (sorry for the wrong bug number)
A litmus test for this would be good.
This means that http://support.mozillamessaging.com/en-US/kb/Safe-Mode will need to be edited.
https://litmus.mozilla.org/show_test.cgi?id=15385 https://litmus.mozilla.org/show_test.cgi?id=15386 https://litmus.mozilla.org/show_test.cgi?id=15387 https://litmus.mozilla.org/show_test.cgi?id=15388 https://litmus.mozilla.org/show_test.cgi?id=15389
Flags: in-litmus?(ludovic) → in-litmus+
You need to log in before you can comment on or make changes to this bug.