Closed
Bug 641813
Opened 14 years ago
Closed 14 years ago
Silence RE-QUEUE messages to enable diffing of verbose verifier output
Categories
(Tamarin Graveyard :: Verifier, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Q1 12 - Brannan
People
(Reporter: trbaker, Assigned: dschaffe)
Details
(Whiteboard: has-patch, loose-end)
Attachments
(1 file, 2 obsolete files)
|
8.12 KB,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
Modify Verifier.cpp to turn off verbose output for phase1 (after it prints "typecheck ...") then back on for phase2 (after it prints "verify ..."). Any differences in the phase2 output would be either bugs or the evidence of the patch doing its job.
Need to turn the hack into a patch to enable/disable each phase separately via shell command line.
|
Reporter | |
Updated•14 years ago
|
Flags: flashplayer-qrb?
Flags: flashplayer-injection-
Flags: flashplayer-bug+
|
|
Reporter | |
Updated•14 years ago
|
Flags: flashplayer-bug+ → flashplayer-bug-
|
|
||
Updated•14 years ago
|
Attachment #519396 -
Attachment is patch: true
|
|
Reporter | |
Updated•14 years ago
|
Summary: Silence RE-QUEUE differences to enable diffing of verbose verifier output → Silence RE-QUEUE messages to enable diffing of verbose verifier output
|
|
Reporter | |
Updated•14 years ago
|
Assignee: nobody → wmaddox
Priority: -- → P3
Target Milestone: --- → Q3 11 - Serrano
|
|
||
Updated•14 years ago
|
Assignee: wmaddox → rreitmai
OS: Windows 7 → Windows XP
|
|
||
Updated•14 years ago
|
Assignee: rreitmai → cpeyer
OS: Windows XP → All
|
|
Reporter | |
Updated•14 years ago
|
Assignee: cpeyer → wmaddox
|
|
Reporter | |
Updated•14 years ago
|
Flags: flashplayer-qrb? → flashplayer-qrb+
|
|
||
Comment 2•14 years ago
|
||
-Dverifyquiet will enable verifyall && verifyonly && quiet RE-QUEUE msgs
Attachment #519396 -
Attachment is obsolete: true
Attachment #525676 -
Flags: review?(rreitmai)
Attachment #525676 -
Flags: review?(cpeyer)
|
|
||
Updated•14 years ago
|
Target Milestone: Q3 11 - Serrano → Q2 11 - Wasabi
|
|
||
Updated•14 years ago
|
Attachment #525676 -
Flags: review?(rreitmai) → review+
|
|
||
Updated•14 years ago
|
Attachment #525676 -
Flags: review?(cpeyer)
|
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 525676 [details] [diff] [review]
CLI option for quiet re-queue msgs
The usage blurb could be clearer as to when you'd want to use -Dverifyquiet but I'm not sure what the correct wording should be.
From an email exchange with Bill:
"the goal was to suppress the output during the iterative typechecking phase, so that only the final results are visible during phase 2"
Maybe the message should be something like " verify greedily, don't execute anything, terse output to facilitate diffing"
Thoughts?
|
|
||
Comment 4•14 years ago
|
||
Good point, I did look at all the options and how they are done. We clearly should re-design that area in the next release.
|
|
||
Comment 5•14 years ago
|
||
ifdef fixed for release build.
Attachment #525676 -
Attachment is obsolete: true
Attachment #525872 -
Flags: review?(rreitmai)
|
|
||
Updated•14 years ago
|
Assignee: wmaddox → akruetzf
|
|
||
Updated•14 years ago
|
Attachment #525872 -
Attachment is patch: true
Attachment #525872 -
Attachment mime type: application/octet-stream → text/plain
|
|
||
Updated•14 years ago
|
Attachment #525872 -
Flags: review?(rreitmai) → review+
|
|
||
Updated•14 years ago
|
Target Milestone: Q2 11 - Wasabi → Q3 11 - Serrano
|
|
||
Updated•14 years ago
|
Whiteboard: Has-patch
Clear for landing in TR, or so it appears.
Whiteboard: Has-patch → has-patch, loose-end
Target Milestone: Q4 11 - Anza → Q1 12 - Brannan
|
|
||
Comment 8•14 years ago
|
||
changeset: 6587:ccd37210df23
user: Dan Schaffer <dschaffe@adobe.com>
summary: Bug 641813 - Add -Dverifyquiet flag to shell, similar to -Dverifyonly but ignores re-queue (patch from akruetzf) (r=rreitmai)
http://hg.mozilla.org/tamarin-redux/rev/ccd37210df23
|
|
Reporter | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•