641842 - Upgrade gcc 4.5 on buildbots

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Mike Hommey [:glandium]]

Building current mozilla central with gcc 4.5 from /tools/gcc-4.5 (I believe this is 4.5.1) with the -O3 patch from bug 590181 applied leads to several failures in various tests (most notably plugin failures and some reftest problems). However, this doesn't happen on a local build with either 4.5.2 from Debian (svn revision 170696) or a plain 4.5.2 from upstream gcc.

As a consequence, could you package gcc 4.5.2 and upgrade gcc on the buildbots?

Comment 1

[Mike Hommey [:glandium]]

Hold on, this is crazy, I can't even reproduce the problem the buildbots exhibit when I use the binaries from try.

Comment 2

[Mike Hommey [:glandium]]

It was pretty dumb... libnptest.so of my try depended on libstdc++ 4.5.

So, now that it's a non issue, do we still want to bump gcc 4.5 version ?

Comment 3

[(not currently active) Ted Mielczarek]

If you don't need the newer version, then I'd just resolve this INCOMPLETE or WONTFIX.

Comment 4

[Mike Hommey [:glandium]]

(In reply to comment #3)
> If you don't need the newer version, then I'd just resolve this INCOMPLETE or
> WONTFIX.

The question was whether there'd be another rationale to push a newer version. Better to bump it before actually switching, if we want to.

Comment 5

[Chris AtLee [:catlee]]

(In reply to comment #4)
> (In reply to comment #3)
> > If you don't need the newer version, then I'd just resolve this INCOMPLETE or
> > WONTFIX.
> 
> The question was whether there'd be another rationale to push a newer version.
> Better to bump it before actually switching, if we want to.

agreed. easier to change now than later.

Comment 6

[Rail Aliiev [:rail]]

(In reply to comment #5)
> agreed. easier to change now than later.

Yeah, risk is very low. Let's upgrade it.

Comment 7

[Rail Aliiev [:rail]]

Attachment: RPM spec changes

I dropped linux64-ffi.diff patch which exists in 4.5.2.

Comment 8

[Rail Aliiev [:rail]]

Attachment: puppet

some of the staging build slaves got this ;)

Comment 9

[Mike Hommey [:glandium]]

Please hold on before building and deploying with this spec file. I may have a request for some specific build flags.

Comment 10

[Rail Aliiev [:rail]]

(In reply to comment #9)
> Please hold on before building and deploying with this spec file. I may have a
> request for some specific build flags.

Sure.

Comment 11

[Mike Hommey [:glandium]]

Turns out the flags I was interested in are used by default, so you can go ahead :)

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 519878 [details] [diff] [review]
RPM spec changes

http://hg.mozilla.org/build/rpm-sources/rev/44f2e9f4c65f

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 519879 [details] [diff] [review]
puppet

http://hg.mozilla.org/build/puppet-manifests/rev/19af7fd3219d

Comment 14

[Rail Aliiev [:rail]]

gcc-4.5.2 deployment has just started. I'll check the result tomorrow.

Comment 15

[Mike Hommey [:glandium]]

Is it possible to get the resulting rpm ?

Comment 16

[Rail Aliiev [:rail]]

Sure: http://people.mozilla.org/~raliiev/gcc/