641864 - Author can't delete or enable self-disabled (incomplete) add-on

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

According to this discussion in the Add-ons Forum: https://forums.mozilla.org/addons/viewtopic.php?f=20&t=2613, the author has an add-on that is self-disabled (not admin-disabled anymore), but he doesn't see the Delete or Enable options.

I can see them on the versions page: https://addons.mozilla.org/en-US/developers/addon/these-toolbars-with-small-icon/versions/, but he can't, apparently. He should be able to see both.

May be related to bug 641292.

Comment 1

[Justin Scott [:fligtar]]

mysql> select id, status from addons where slug='these-toolbars-with-small-icon';
+------+--------+
| id   | status |
+------+--------+
| 3914 |      0 | 
+------+--------+

weird.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Note that bug 641292 was resolved without any problems. I'll ask the author to send a screenshot of the Versions page.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: My Add-ons page for currently Incomplete add-on

Here are some screenshots provided by the author at https://forums.mozilla.org/addons/viewtopic.php?f=20&t=2613&p=7431#p7431

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Status & Versions page for currently Incomplete add-on

In the previous screenshot you can see the "you need to nominate or your add-on will be disabled" message, which I assume shouldn't appear anymore. In this one, you can see that there are no options to Delete or Enable the add-on.

This add-on is in an Incomplete state, so it should be possible to do all these things. Apparently there's a problem handling the Inactive (self-disabled) status.

Comment 5

[Kumar McMillan [:kumar]]

(In reply to comment #1)
> mysql> select id, status from addons where
> slug='these-toolbars-with-small-icon';
> +------+--------+
> | id   | status |
> +------+--------+
> | 3914 |      0 | 
> +------+--------+

Well, this certainly is intentional.  Addons are set to STATUS_NULL when the user disables them.  Andym may have more insight into it since he's in the blame log for the change.

Comment 6

[Justin Scott [:fligtar]]

We shouldn't be touching the add-on status when addons.inactive is changed... that's why they are separate fields.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

To clarify, this is the timeline of status changes:

1) Author uploads add-on.
2) Author disables add-on (add-on is now inactive).
3) We disable the add-on (add-on is now admin-disabled AND inactive).
4) Author requests add-on to be deleted.
5) I enable the add-on. (add-on is now incomplete AND inactive).

In this final state, the author should be able to change the add-on back to active, or delete it. None of those options are available, apparently, so that's the bug that need to be fixed.

Comment 8

[Andy McKay]

I think Kumar is refering to the code added in bug 569949. Without files or versions, the addon gets moved to null. A simple change would be stop changing the status if the addon is inactive as noted in comment 6.

Comment 9

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/6344d69005e98e008946ac4d3265a86bbce1b659

If an addon is disabled (by admin or user) we won't try and alter its status.

Comment 10

[krupa raj[:krupa]]

Using STR from comment 7 I was able to enable/delete my add-on @ https://addons-next.allizom.org/en-US/developers/addon/zoom13/versions/

Comment 11

[[e-mail]]

Hi,

I have the same problem: cannot delete/re-enable my add-on.

Several months ago I added and then disabled an add-on. Now I want to enable it and submit a new version. But there is no way to do it. And I don't want to change add-on ID. Add-on page tells me that
"You have disabled this add-on. Your add-on's listing is disabled and is not showing anywhere in our gallery or update service. You may re-enable it at any time below."
But in fact the corresponding buttons are disabled. Could anyone please help me with this issue?

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

Can you please give us a link to your add-on? Thanks.

Comment 13

[[e-mail]]

Here it is
https://addons.mozilla.org/en-US/developers/addon/adlesse/versions/

Comment 14

[Jorge Villalobos [:jorgev] (he/him)]

The problem with your add-on was that it was also admin-disabled. I've fixed its status now and filed bug 677559. Let me know if you run into any other problems.

Comment 15

[Atlassian]

Hi!
Jorge, looks like the problem still exists.

My add-on status is 'You have disabled this add-on'. Status does not change if I submit a new version.
I think the add-on might be admin-disabled too, as previous version recently has been under a review.

My add-on link is
https://addons.mozilla.org/en-US/developers/addon/capture-for-jira/versions

I'd like the status to be updated & the new review to be initiated.

Thanks a lot!

--
Cheers,
Ignat.

Comment 16

[Jorge Villalobos [:jorgev] (he/him)]

It looks like a new problem. I filed bug 1223528.

Comment 17

[Ignat Alexeyenko]

Thanks Jorge! I'll be watching the issue you've filled.