641879 - Malformed search queries return 500 Internal Server Errors

Status: VERIFIED FIXED

(Socorro :: General, task, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

The following queries are all producing 500 Internal Server Errors:

500 HTTP Error code with Vulnerable URL: https://crash-stats.stage.mozilla.com/query/query?query_type=http%3A%2F%2Fwww.google.com%2F&do_query=1&query=%2F

500 HTTP Error code with Vulnerable URLhttps://crash-stats.stage.mozilla.com/query/query?query_type=a%3Benv&do_query=1&query=%2F

500 HTTP Error code with Vulnerable URL: https://crash-stats.stage.mozilla.com/query/query?query_type=%BF%27%22%28&do_query=1&query=%2F

500 HTTP Error code with Vulnerable URL: https://crash-stats.stage.mozilla.com/query/query?query_type=<script>var+pf_68747470733a2f2f63726173682d73746174732e73746167652e6d6f7a696c6c612e636f6d2f71756572792f7175657279_71756572795f74797065=new+Boolean();</script>&do_query=1&query=/

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: default to simple search, ignore invalid querytype

Since $params['query_type'] is UGC, ignore it if it's not in our list of valid query types and default to 'simple'.

Comment 2

[Robert Helmer [:rhelmer]]

Committed revision 3009.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using https://crash-stats.stage.mozilla.com/query/query?query_type=http%3A%2F%2Fwww.google.com%2F&do_query=1&query=%2F.  Filed follow-up bug 642580 to deal with a bunch of others.