Open Bug 641893 Opened 13 years ago Updated 1 year ago

crash in nsWindow::WindowProcInternal

Categories

(Core :: Widget: Win32, defect, P5)

x86
All
defect

Tracking

()

REOPENED
Tracking Status
firefox14 - ---
firefox15 - ---

People

(Reporter: marcia, Unassigned)

Details

(Keywords: crash, Whiteboard: tpi:+, qa-not-actionable)

Crash Data

Seen while reviewing crash stats. Currently ranks as #114 top crash.

https://crash-stats.mozilla.com/report/index/012a0395-9f83-4462-87d9-a1b2d2110313

High correlation to Personas Plus: 72% (28/39) vs.   3% (2362/78012) personas@christopher.beard (Personas, https://addons.mozilla.org/addon/10900)

Frame 	Module 	Signature [Expand] 	Source
0 		@0x72616f62 	
1 	xul.dll 	nsWindow::WindowProcInternal 	
2 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
3 	xul.dll 	CallWindowProcCrashProtected 	xpcom/base/nsCrashOnException.cpp:65
4 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
5 	xul.dll 	xul.dll@0x35bddd 	
6 	xul.dll 	nsWindow::WindowProc 	widget/src/windows/nsWindow.cpp:4561
7 	xul.dll 	xul.dll@0xac94f 	
8 	user32.dll 	InternalCallWinProc 	
9 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
10 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
11 	user32.dll 	UserCallWinProcCheckWow 	
12 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
13 	user32.dll 	StringDuplicateW 	
14 	user32.dll 	UserCallWinProcCheckWow 	
15 	user32.dll 	DispatchClientMessage 	
16 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
17 	xul.dll 	nsRefPtr<mozilla::layers::SwapChainD3D9>::~nsRefPtr<mozilla::layers::SwapChainD3D9> 	xpcom/base/nsAutoPtr.h:970
18 	user32.dll 	__fnDWORD 	
19 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
20 	ntdll.dll 	ntdll.dll@0xe472 	
21 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
22 	user32.dll 	TestWindowProcess 	
23 	user32.dll 	NtUserPeekMessage 	
24 	user32.dll 	_PeekMessage 	
25 	user32.dll 	GetShellWindow 	
26 		@0xe 	
27 	xul.dll 	nsWindow::DealWithPopups 	widget/src/windows/nsWindow.cpp:8940
28 	user32.dll 	TestWindowProcess 	
29 	user32.dll 	NtUserDispatchMessage 	
30 	user32.dll 	__fnDWORD 	
31 	user32.dll 	DispatchMessageWorker 	
32 	user32.dll 	GetShellWindow 	
33 	mozjs.dll 	js_strtod 	js/src/jsnum.cpp:1452
34 	winmm.dll 	timeGetTime 	
35 	nspr4.dll 	PR_IntervalNow 	nsprpub/pr/src/misc/prinrval.c:77
36 	xul.dll 	nsBaseAppShell::OnProcessNextEvent 	widget/src/xpwidgets/nsBaseAppShell.cpp:333
37 	nspr4.dll 	PR_GetCurrentThread 	nsprpub/pr/src/threads/combined/pruthr.c:1479
38 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:597
39 	nspr4.dll 	PR_AssertCurrentThreadOwnsLock 	nsprpub/pr/src/threads/combined/prulock.c:404
40 	xul.dll 	mozilla::ipc::MessagePump::Run 	ipc/glue/MessagePump.cpp:134
41 	xul.dll 	MessageLoop::RunInternal 	ipc/chromium/src/base/message_loop.cc:219
42 	xul.dll 	MessageLoop::RunHandler 	ipc/chromium/src/base/message_loop.cc:202
43 	mozcrt19.dll 	_VEC_memzero 	
44 	xul.dll 	xul.dll@0x35bddd 	
45 	xul.dll 	MessageLoop::Run 	ipc/chromium/src/base/message_loop.cc:176
46 	xul.dll 	nsBaseAppShell::Run 	widget/src/xpwidgets/nsBaseAppShell.cpp:192
47 	xul.dll 	xul.dll@0xb367c7 	
48 	xul.dll 	nsAppStartup::Run 	toolkit/components/startup/src/nsAppStartup.cpp:220
49 	xul.dll 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3786
50 	firefox.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp:128
51 	firefox.exe 	__tmainCRTStartup 	obj-firefox/memory/jemalloc/crtsrc/crtexe.c:591
52 	kernel32.dll 	BaseProcessStart
Looks like popups + layers + D3D?
We need a real stack for that crash; this one doesn't make sense. Loading a minidump into MSVC with the relevant build will be enough.
looks like there are a few different forms of this stack.  here are the top 4.

rest are listed at
http://people.mozilla.org/crash_stacks/reports/stack-summary-nsWindow::WindowProcInternal.HWND__...unsigned.int,.unsigned.int,.long..txt


...Signature number: 1-nsWindow::WindowProcInternalHWND__unsignedint,unsignedint,long
______ distribution of 100 different stacks, looking at top 10 frames
     37  stacks like
0|0||
0|1|xul.dll|nsWindow::WindowProcInternal(HWND__ *,unsigned int,unsigned int,long)
0|2|xul.dll|CallWindowProcCrashProtected
0|3|xul.dll|
0|4|xul.dll|nsWindow::WindowProc(HWND__ *,unsigned int,unsigned int,long)
0|5|xul.dll|
0|6|user32.dll|InternalCallWinProc
0|7|user32.dll|UserCallWinProcCheckWow
0|8|xul.dll|CallWindowProcCrashProtected
0|9|user32.dll|UserCallWinProcCheckWow

     31  stacks like
0|0||
0|1|xul.dll|nsWindow::WindowProcInternal(HWND__ *,unsigned int,unsigned int,long)
0|2|xul.dll|CallWindowProcCrashProtected
0|3|xul.dll|CallWindowProcCrashProtected
0|4|xul.dll|CallWindowProcCrashProtected
0|5|xul.dll|
0|6|xul.dll|nsWindow::WindowProc(HWND__ *,unsigned int,unsigned int,long)
0|7|xul.dll|
0|8|user32.dll|InternalCallWinProc
0|9|xul.dll|CallWindowProcCrashProtected

     17  stacks like
0|0||
0|1|xul.dll|nsWindow::WindowProcInternal(HWND__ *,unsigned int,unsigned int,long)
0|2|user32.dll|IsWindowVisible
0|3|xul.dll|CallWindowProcCrashProtected
0|4||
0|5|user32.dll|wcscpy_s
0|6|user32.dll|DispatchClientMessage
0|7|xul.dll|CallWindowProcCrashProtected
0|8|xul.dll|nsRefPtr&lt;mozilla::layers::SwapChainD3D9&gt;::~nsRefPtr&lt;mozilla::layers::SwapChainD3D9&gt;()
0|9|user32.dll|__fnDWORD

      3  stacks like
0|0||
0|1|xul.dll|nsWindow::WindowProcInternal(HWND__ *,unsigned int,unsigned int,long)
0|2|user32.dll|HMValidateHandleNoRip
0|3|xul.dll|CallWindowProcCrashProtected
0|4||
0|5|user32.dll|wcscpy_s
0|6|user32.dll|DispatchClientMessage
0|7|xul.dll|CallWindowProcCrashProtected
0|8|xul.dll|nsRefPtr&lt;mozilla::layers::SwapChainD3D9&gt;::~nsRefPtr&lt;mozilla::layers::SwapChainD3D9&gt;()
0|9|user32.dll|__fnDWORD
Crash Signature: [@ nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ]
crash-stats.mozilla.com linked my crash in bug 682041 to this bug 641893. Does it mean it is the same stack trace? Are these bugs the same? If yes, see the steps to reproduce there.
Using steps in bug 682041 I can make FF6 crash even on this bugzilla page (https://crash-stats.mozilla.com/report/index/bp-e26d0137-2ff2-4f73-8049-13a9c2110826).

For comment 1, I have D3D disabled by FF, don't know about layers accel (probably disabled too) and I am not using the addon Personas Plus. But I have a Persona theme enabled. Win XP, 32bit.
However, it crashes even in safe mode with the persona disabled:
https://crash-stats.mozilla.com/report/index/bp-8d1116ad-7961-4dd5-a766-d9e732110826
Bug 682041 is now fixed and verified. Do we mark this as duplicate? Do we need to wait on all users to move onto Firefox 9 and then see if the number of crashes with this signature goes down?
Keywords: crashreportid
Whiteboard: [dupeme 682041 on 2012-01-15]
It's #186 top browser crasher in 13.0.1, #38 in 14.0b11, and #54 in 15.0a2
Crashes appeared in 14.0a1/20120408 and stopped after 16.0a1/20120618.

It's not a dupe of bug 723133.

More reports at:
https://crash-stats.mozilla.com/report/list?signature=nsWindow%3A%3AWindowProcInternal%28HWND__*%2C+unsigned+int%2C+unsigned+int%2C+long%29
https://crash-stats.mozilla.com/report/list?signature=%400x0+|+nsWindow%3A%3AWindowProcInternal%28HWND__*%2C+unsigned+int%2C+unsigned+int%2C+long%29
Severity: normal → critical
Crash Signature: [@ nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ] → [@ nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ] [@ @0x0 | nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ]
Keywords: crashreportidtopcrash
OS: Windows XP → All
Summary: Firefox 4.0 Crash [@ nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ] (personas plus?) → crash in nsWindow::WindowProcInternal
Whiteboard: [dupeme 682041 on 2012-01-15]
This is a very low volume crash, with only a few spikes occasionally and then back to none. Un-tracking for 14 & 15. Renominate if crashes occur and stay present.
Firefox 16.0.2 crashed for me on Windows 8. In the moment of the crash I had several tabs opened, at first Firefox hanged and after that it crashed.

https://crash-stats.mozilla.com/report/index/bp-fc2bc013-6543-42de-a8b3-c47e02121115
Crash Signature: [@ nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ] [@ @0x0 | nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ] → [@ nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ] [@ @0x0 | nsWindow::WindowProcInternal(HWND__*, unsigned int, unsigned int, long) ] [@ nsWindow::WindowProcInternal ] [@ @0x0 | nsWindow::WindowProcInternal ]
Priority: -- → P4
Whiteboard: tpi:+
Priority: P4 → P5

Reopening bug since there are crash reports in the last 6 months.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Whiteboard: tpi:+ → tpi:+, qa-not-actionable
Severity: critical → S2

Since the crash volume is low (less than 5 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Severity: S2 → S3
You need to log in before you can comment on or make changes to this bug.