641983 - Selecting a canned response should not delete current text

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Choosing a canned response should insert the text in the current cursor position and it shouldn't do anything to the currently entered text. They are not final responses but snippets that are cobbled together into a hopefully comprehensible review. So, we tend to use many of those in a single review.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

I guess the text can be confusing. Something like "Insert canned response" instead of "Or, select a canned response" would make more sense.

Comment 2

[Gregory Koberger (:gkoberger)]

Okay, I'll change it.  I did it this way intentionally, since I figured people would be more likely to cycle through them to find the one they wanted than to use more than one.  But if that's not the case, I'll change the functionality and the wording :)

Comment 3

[Gregory Koberger (:gkoberger)]

http://github.com/jbalogh/zamboni/commit/49099c1

Comment 4

[krupa raj[:krupa]]

(In reply to comment #1)
> I guess the text can be confusing. Something like "Insert canned response"
> instead of "Or, select a canned response" would make more sense.

It still says "Or, select a canned response"

Comment 5

[krupa raj[:krupa]]

Attachment: screenshot

Comment 6

[Gregory Koberger (:gkoberger)]

http://github.com/jbalogh/zamboni/commit/0ae4752

Krupa, stop QAing and go to bed!!! :)

Comment 7

[krupa raj[:krupa]]

verified @ https://addons.allizom.org/z/en-US/editors/review/398568?num=2

Comment 8

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...