Closed
Bug 641998
Opened 13 years ago
Closed 13 years ago
Locales are not displayed on Facebook Badges page
Categories
(Websites :: Facebook, defect)
Websites
Facebook
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stas, Assigned: allia.z)
References
()
Details
Attachments
(1 file)
428 bytes,
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #641119 +++ https://www.facebook.com/pages/Firefox-4/130379370362344?sk=app_122300121174636 is always in English, independently of the user's prefs on fb.
Updated•13 years ago
|
Assignee: server-ops → jeremy.orem+bugs
Reporter | ||
Comment 1•13 years ago
|
||
In case anyone gets to this before I wake up: Looking at the code at <https://svn.mozilla.org/projects/mozilla.com/branches/firefox4/en-US/firefox/fb-badges/index.html>, please change /* Set the Locale */ $locale = $user["user"]["locale"]; putenv("LC_ALL=" . $locale); setlocale(LC_ALL, $locale); to /* Set the Locale */ $locale = $user["user"]["locale"]; echo $locale; putenv("LC_ALL=" . $locale); echo setlocale(LC_ALL, $locale); What does it echo when you access <https://www.facebook.com/pages/Firefox-4/130379370362344?sk=app_122300121174636>? Can you repeat this after temporarily changing your lang prefs on Facebook to a different locale than en-US? Thanks!
Updated•13 years ago
|
Assignee: jeremy.orem+bugs → shyam
Reporter | ||
Comment 2•13 years ago
|
||
I debugged this with Shyam and it turned out to be a bug in the code. I'll attach a patch in a sec.
Assignee: shyam → nobody
Component: Server Operations → Facebook
Product: mozilla.org → Websites
QA Contact: mrz → facebook
Reporter | ||
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
Assigning to Zach so he imports it into the upstream SVN.
Assignee: nobody → allia.z
Reporter | ||
Comment 5•13 years ago
|
||
Any chance that this can be fixed today, please?
Comment 6•13 years ago
|
||
(In reply to comment #5) > Any chance that this can be fixed today, please? Zach has been emailed ... I think we're waiting on him or has this already been committed to svn?
Comment 7•13 years ago
|
||
Update: just talked with Zach and he's going to have this patched in the next couple hours. He's also tweaking the CSS styles for locales. Stand by.
Reporter | ||
Comment 8•13 years ago
|
||
(In reply to comment #7) > He's also tweaking the CSS styles for locales. In fact, I don't think he should do this. If he applies the patch Gandalf sent by email to enable custom-css, localizers and the l10n team will be able to tweak the CSS instead.
Assignee | ||
Comment 9•13 years ago
|
||
commited gandalf's fix and this fix
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 10•13 years ago
|
||
I pulled the L10n-related commit into our SVN in r85307.
Reporter | ||
Comment 11•13 years ago
|
||
w00t! The stage works now!
Comment 12•13 years ago
|
||
Nice! Both William and I see this awesomeness working... marking QA Verified so we can kick off the formal test cycle.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•