642083 - Validator: Binaries aren't "disallowed"

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Nils Maier [:nmaier]]

Binaries currently give a warning along the lines of:
>Blacklisted file extension found
>
>Warning: The file "%s" uses a blacklisted file extension.
>
>Warning: The extension dll is disallowed.

This is incorrect; binary components are allowed but require to have the source sent to admins, and such add-on require super-review. (Except for nplugins, which are in fact disallowed)

The warning should be rephrased. The Remora warning was:
>The add-on contains a file '%s', which is a flagged type.

Hence I propose:
>Flagged file found
>
>Warning: The file "%s" has a flagged file extension.
>
>Warning: The extension "%s" is flagged, because it usually identifies binary components. Please see <a href="/developers/docs/policies/reviews#section-binary">Review Process - Binary Components</a>. If it isn't a binary component, you're strongly advised to change the file extension to something else.

Comment 1

[Nils Maier [:nmaier]]

Jorge, can you verify this, please?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #1)
> Jorge, can you verify this, please?

Yes, the message is too strong. I agree with the proposal, but I wouldn't include the last sentence ("If it isn't a binary component...").

Comment 3

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/pull/10

Comment 4

[krupa raj[:krupa]]

This is not in zamboni yet

Comment 5

[krupa raj[:krupa]]

I still see the old warning. See https://addons.allizom.org/en-US/developers/upload/c4771f01310946cab7d7bed24dfca3fb

Jorgev, can you take a look and confirm?

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Yeah, this isn't fixed yet.

Comment 7

[Matt Basta [:basta]]

Hrm... looks like some changes didn't come along with that commit. My b. It's fixed now:

https://github.com/mozilla/amo-validator/commit/eb80559d6122c4419b6c01ecfe3ba4c14a98285b

Comment 8

[krupa raj[:krupa]]

verified fixed @ https://addons.allizom.org/en-US/developers/upload/a465258851b841ac8feab2f13b854b71

Comment 9

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...