Validator: Binaries aren't "disallowed"

VERIFIED FIXED in 6.0.4

Status

P3
minor
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: nmaier, Assigned: basta)

Tracking

unspecified
6.0.4

Details

(Whiteboard: [ReviewTeam])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Binaries currently give a warning along the lines of:
>Blacklisted file extension found
>
>Warning: The file "%s" uses a blacklisted file extension.
>
>Warning: The extension dll is disallowed.

This is incorrect; binary components are allowed but require to have the source sent to admins, and such add-on require super-review. (Except for nplugins, which are in fact disallowed)

The warning should be rephrased. The Remora warning was:
>The add-on contains a file '%s', which is a flagged type.

Hence I propose:
>Flagged file found
>
>Warning: The file "%s" has a flagged file extension.
>
>Warning: The extension "%s" is flagged, because it usually identifies binary components. Please see <a href="/developers/docs/policies/reviews#section-binary">Review Process - Binary Components</a>. If it isn't a binary component, you're strongly advised to change the file extension to something else.
(Reporter)

Comment 1

8 years ago
Jorge, can you verify this, please?
Assignee: nobody → mbasta
(In reply to comment #1)
> Jorge, can you verify this, please?

Yes, the message is too strong. I agree with the proposal, but I wouldn't include the last sentence ("If it isn't a binary component...").
Severity: normal → minor
Priority: -- → P3
Whiteboard: [required amo-editors]
Target Milestone: --- → 6.0.3
(Assignee)

Comment 3

8 years ago
Fixed:

https://github.com/mozilla/amo-validator/pull/10
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 4

8 years ago
This is not in zamboni yet

Comment 5

8 years ago
I still see the old warning. See https://addons.allizom.org/en-US/developers/upload/c4771f01310946cab7d7bed24dfca3fb

Jorgev, can you take a look and confirm?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Yeah, this isn't fixed yet.
Target Milestone: 6.0.3 → 6.0.4
(Assignee)

Comment 7

8 years ago
Hrm... looks like some changes didn't come along with that commit. My b. It's fixed now:

https://github.com/mozilla/amo-validator/commit/eb80559d6122c4419b6c01ecfe3ba4c14a98285b
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED

Comment 9

8 years ago
Created attachment 524557 [details]
post-fix screenshot
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.