642091 - No restore session button in about:home after a 4.0 pave over 3.6 install

Status: VERIFIED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[AndreiD[QA]]

STRs:
1. Navigate in Firefox 3.6.13; set the maximum resume crashes to 1
2. Crash Firefox;
3. Perform a pave over install of the 4.0 RC version; when the installer finishes, launch Firefox.

Actual results:
3. Firefox 4.0 opens up with the "What's new" tab and the "about:home" tab without the "restore session" button

Expected results
3. "About:home" is expected to have the "restore session" button after the install

*NOTE: there is no info in the "about:sessionrestore" right after the install.

Comment 1

[u279076]

I'm unable to reproduce this from Firefox 3.6.15 nor 3.6.13.  Here is my steps:

1. Install Firefox 3.6.x
2. Set "When Firefox Starts" to "Show windows and tabs from last time"
3. Open www.google.ca, www.arstechnica.com, and www.digg.com in three separate tabs
4. Install crashme-advanced.xpi and restart
5. Trigger a crash using Crash Me
6. Select "Quit" from the crash reporter
7. Install Firefox 4.0rc1 to the same folder as Firefox 3.6.x
8. Start Firefox

Result:
Tabs are restored with "Firefox Updated" loaded in a 4th tab

NOTE: I did not change the browser.sessionstore.max_resumed_crashes because it defaults to 1.

I'm marking as UNCONFIRMED until we can get a reliable set of steps to reproduce this bug.

Comment 2

[u279076]

Just another set of steps to consider:

1. Install Firefox 3.6.x
2. Set "When Firefox Starts" to "Show my home page"
3. Open google.ca, arstechnica.com, and digg.com in 3 tabs
4. Install crashme-advanced.xpi and restart
5. Trigger a crash using Crash Me and select "Restart"
6. Trigger a crash using Crash Me and select "Quit"
7. Install Firefox 4.0rc1 to the same folder as Firefox 3.6.x
8. Start Firefox

Result:
about:sessionstore in the first tab and "Firefox Updated" in a 2nd tab.  Session is restorable from the first tab.

Comment 3

[u279076]

One final set of steps to consider:

1. Install Firefox 3.6.x and start with a new profile
2. Install crashme-advanced.xpi and restart
3. Trigger a crash using Crash Me and select "Quit"
4. Install Firefox 4.0rc1 to the same folder as Firefox 3.6.x
5. Start Firefox

Result:
Firefox 3.6 welcome page still loaded in the first tab. "Firefox Updated" loaded in a second tab.

Comment 4

[u279076]

As you can see from all three of my attempts, I'm unable to manifest this bug under any scenario.

Comment 5

[u279076]

CCing Paul on this bug in case he has seen something like this before. FWIW, even if I could reproduce this bug, I wouldn't block Firefox 4 for it. I don't think this is a common upgrade path for the majority of users.

Comment 6

[AndreiD[QA]]

I checked all of the scenarios above and got the same results as in the Comments. Thanks Anthony.
Although, please check the screenshot attached. If considering the scenario in Comment#2, after the pave over install, if opening about:home, there will be no "restore session" button. 
It is unclear for me if there should be one in this case or not.

Comment 7

[AndreiD[QA]]

Attachment: ScreenShotNoHomeButton

Comment 8

[u279076]

(In reply to comment #7)
> Created attachment 519858 [details]
> ScreenShotNoHomeButton

I believe if you manually navigate to about:home you will not get the Restore Session button (correct me if I am wrong, Paul). If Paul thinks it's valid, please file a new bug as it is a separate issue from the one in this bug.

Marking this as WORKSFORME.

Comment 9

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #8)
> I believe if you manually navigate to about:home you will not get the Restore
> Session button

You're mostly correct :)

Under normal startup circumstances where a non-crashing session is not restored, then about:home will show the button. Once the session is restored, then there won't be a button on any new about:home instances.

If the previous session crashes and we load about:sessionrestore at startup, then about:home won't show the button.