Closed Bug 64218 Opened 24 years ago Closed 24 years ago

History Sidebar

Categories

(Core :: DOM: Navigation, defect, P2)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.8

People

(Reporter: alecf, Assigned: alecf)

Details

(Whiteboard: fix in hand)

Attachments

(1 file)

split up history.xul into overlay, and make the panel
21.22 KB, patch
Details | Diff | Splinter Review 
I have implemented a basic history sidebar. Currently it just shares the same
tree XUL as the history window.. this bug is just for the fact that it exists.
Future enhancements to this should go in seperate bugs.

patch forthcoming.
gack, reassigning back to me
Assignee: radha → alecf
that patch also contains the fixes for bug 63613 and bug 37078. Bug 63613 still
has some controversey surrounding the Paste menu item, so I won't check in until
that is resolved.
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: fix in hand
Target Milestone: --- → mozilla0.8
Cool, thanks for doing this.

+  <rdf:Description about="urn:sidebar:panel:history">
+    <nc:title>&sidebar.bookmarks.label;</nc:title>
+    <nc:content>chrome://communicator/content/history/history-
panel.xul</nc:content>
+  </rdf:Description>

Shouldn't that be &sidebar.history.label?
 
oops! good call. Fixed in my tree.. if there are other things to fix, I'll
attach a new patch..
Looks good to me.  I don't think we need that drag dump, and "bookmarksTree" 
isn't the most intuitive name for a history tree (but there is, iirc, some 
silly code that depends on that being the name?), but r=blake
OS: Windows 2000 → All
Hardware: PC → All
(s/name/id)
\ No newline at end of file
Keywords: approval, patch, review
Keywords: review
See also bug 32594, looks like there is some effort duplication here
you're right, these are dupes of each other. however, I believe my fix to be the
"better" of the two fixes because I am making the history window and the history
sidebar share the same tree.

On a side note, I know that "bookmarksTree" is a bad name of course, but I
haven't completely evaluated if we've exorcised the use of "bookmarksTree" from
the code that we share with the bookmarks window. Once I have done that, I'll
fix that in another bug. In the meantime, we have this. :)

I've fixed the newline, and removed the useless dump() in my tree.
Ben, can you a= alec's patch?
this looks a lot like bug 32597, although there seem to be two completely
different patches for them. Should one of them be marked duplicate?
What am I talking about? Disregard last comment please (typed the wrong bug
number AND someone had already said so). ::smacks self on head::
seems ok, a=ben@netscape.com,

I'm interested to know what crappy bookmarks code relies on your tree being 
called 'bookmarksTree', if it still exists (probably not in my heavily modified 
tree), it should be whacked. 
there are a few places, check LXR :)
thanks
fix is in. there are bound to be quirks, but the basic functionality is there.
(i.e. if you find a bug, file a new one, don't reopen this one)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
OT (sorry but ppl following this bug might be interested):

What does one have to do to see this new sidebar - delete prefs.js, or worse,
create a new user profile? Any other way?
Verified with build 2001011820 on NT4.
Nice to have that! (Although it's still a bit slow.)
just hit "Customize" in the sidebar, and pick it from the list shown
VERIFIED FIXED on Windows 2000, build 2001020504, Mac 2001020513 and Linux
2001020506.
Status: RESOLVED → VERIFIED
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: