Closed
Bug 642233
Opened 15 years ago
Closed 15 years ago
Twitter Party: Add dir="rtl" for RTL locales
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stas, Unassigned)
References
()
Details
Attachments
(2 files)
Layout glitch in the mozilla logo
For [ar] and [he], please add dir="rtl" to the <html/> or the <body/> element.
|
||
Comment 1•15 years ago
|
||
Done.
We used the rtl locale list found in Mozilla's localeDetails class.
We added <html dir="ltr|rtl"> and <body class="ltr|rtl">
|
|
||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 2•15 years ago
|
||
Thanks Andre.
I can see a tiny glitch on http://dev.twitterparty.quodis.com/he (and ar), see the attachment. Not sure if it's worth reopening this bug for this.
Some bubbles didn't display properly when "@" was the first character, but I didn't find a way to fix this easily. I think it's OK to leave this at this point. (I can't attach a screenshot, because the bubbles don't show to me at all right now.)
|
|
||
Comment 3•15 years ago
|
||
Bubbles not showing in "ar" because localization is using an unsupported code (TIMEZONE) in the date format. I sent Stas an email with details, maybe a ticket should be opened with this.
|
|
||
Comment 4•15 years ago
|
||
Filed bug 642522 in response to comment 3
|
|
Reporter | |
Comment 5•15 years ago
|
||
Hmm, didn't get anything from you Andre. But I can see the bubbles now :)
Attached is the screenshot of the "@" issue. If a tweet is an @-reply to someone, the "@" is shown on the right hand side of the bubble (because it obeys the RTL direction of the div instead of obeying the LTR direction of the text node).
A solution might be to add dir="ltr" on the tweet bubble since most of the tweets are LTR anyways. I haven't been successful in doing that, however. The bubble layout would break badly with dir="ltr" on it.
|
|
||
Comment 6•15 years ago
|
||
Filed bug 642525 in response to glitch mentioned in comment 2
|
|
||
Comment 7•15 years ago
|
||
@Stas, contents of my email:
«Just noticed that the hebraic translation is using timezone in the date format.
This is not supported by our date formatting function (sorry, we did not point out which features of the PHP formatting syntax http://pt.php.net/manual/en/function.date.php are not supported, but we never timezone was going to be used).
Also, I've noticed that month names won't be translated.
If it's still acceptable to work this (given the code "freeze" urgency) we can still try some workaround for this. Off course, month names will have to be in all translations. We can manually force these with a key such as _('month1'); ... through 12 and then pass on the localization of all months to the javascript.»
|
|
||
Comment 8•15 years ago
|
||
Filed bug 642529 in response to Comment 5. Verified dir=rtl displays in source for /ar and /he.
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Comment 9•15 years ago
|
||
Thanks, Rebecca, for filing the follow-ups.
|
|
||
Comment 10•15 years ago
|
||
@Andre & @Stas, filed bug 642537 in response to comment 7. I verified the original issue for this bug, and separated this issue out to be discussed there. Thanks
|
Assignee | |
Updated•13 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•