642274 - Provide a way to compare to jsvals with '=='

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shawn Wilsher :sdwilsh]

You can compare two jsvals strictly ('==='), but there is no API to do a simple equality comparison ('==').  This would be handy to have.

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Loose equality API.

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Loose equality API.

Forgot to hg add the tests.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 520027 [details] [diff] [review]
Loose equality API.

> bool
>+LooselyEqual(JSContext *cx, const Value &lval, const Value &rval, JSBool *result)

This should probably start off with the XML equality check, h8.

Arguably this should be always-inline for parity with current behavior, but if we can get away with not having to over-specify that, sounds good to me.  Keep an eye on perf numbers when you land this.

We have a somewhat strange way of phrasing the spec algorithm with respect to DefaultValue-ing and stuff.

Make sure to add documentation for this to MDN -- looks like you can just copy the JS_StrictlyEqual page and make a couple tweaks.

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/tracemonkey/rev/d4c0875dc41a
https://developer.mozilla.org/En/SpiderMonkey/JSAPI_Reference/JS_LooselyEqual

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/tracemonkey/rev/cfe6c2e05c07 (backout due to test bustage)

Comment 6

[Shawn Wilsher :sdwilsh]

When might this land again?

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/tracemonkey/rev/d10c089a6888

Comment 8

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/d10c089a6888