642298 - Add jitflags to tinderbox output

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Paul Biggar]

Attachment: Add jitflags to tinderbox output

Add jitflags to tinderbox output. I use |make check| fairly regularly, and also read the jaegermonkey tinderbox output, so I find this useful.

Here's what the output looks like now. Ted says that the output is made-up, and I believe the tinderbox parser doesn't require any format after the first '|'.

TEST-PASS | jit_test.py                | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js
TEST-PASS | jit_test.py -m             | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js
TEST-PASS | jit_test.py -j             | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js
TEST-PASS | jit_test.py -m -j          | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js
TEST-PASS | jit_test.py -m -j -p       | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js
TEST-PASS | jit_test.py -a -m          | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js
TEST-PASS | jit_test.py -a -m -j       | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js
TEST-PASS | jit_test.py -a -m -j -p    | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js
TEST-PASS | jit_test.py -a -m -d       | /Users/pbiggar/work/mozilla/js_tests_in_make_check/js/src/jit-test/tests/basic/inArrayTest.js

Comment 1

[Paul Biggar]

Attachment: Add jitflags to tinderbox output

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 521348 [details] [diff] [review]
Add jitflags to tinderbox output

I think Dave's your man for these files.

Comment 3

[David Mandelin [:dmandelin]]

I notice this patch changes the number of | characters in the output lines. Is the Tinderbox parser OK with that? It might be, but I'm not sure.

Bob, do you know exactly what Tinderbox requires?

Comment 4

[Paul Biggar]

I've noticed that tbpl hunts down related bugs based on the second column. For jstests.py, I made sure the path was left in there, since that's what we want tbpl to search for. For jit-test.py, the string "jit-test.py" was already in the second column, so I just added it there, and I believe it's no harm. However, I can move the path the second column, unless there's a reason not to.

Comment 5

[Bob Clary [:bc] (inactive)]

I think jmaher, jgriffin or mcote are up to date with the tbpl requiremetns. Can you guys answer David's question in comment 3 ?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

if this passes on try, then we should be fine.  I know that the tinderbox parsers are very specific in their regex, usually at the beginning of the line. 

here is what I think will be the code that parses:
http://mxr.mozilla.org/mozilla/source/webtools/tinderbox/ep_unittest.pl

It looks like we would do something like this / TEST-PASS | name(.+)$/

Some thing to keep in mind is we are actually looking for things past the first | to match what type of test this is. 

Again, try server is your best friend:)

Comment 7

[Paul Biggar]

OK, this passes try server and I can see that the tbpl parser has the right number of checks.

Comment 8

[David Mandelin [:dmandelin]]

Comment on attachment 521348 [details] [diff] [review]
Add jitflags to tinderbox output

Sounds good, then. I think there might be a little inconsistency with the way spaces appear around the "|" characters, so maybe recheck that to make sure it prints the way you want.

Comment 9

[Paul Biggar]

(In reply to comment #8)
> Comment on attachment 521348 [details] [diff] [review]
> I think there might be a little inconsistency with the way
> spaces appear around the "|" characters, so maybe recheck that to make sure it
> prints the way you want.

Yeah, that's deliberate. In jit-test it occurs mid-string, so I want to keep a standard length. In jstests it's at the end, so no need to keep the standard length. Also, I deliberately sandwiched %-15s up against '|' because we almost never use 15 spaces, but if I used 14 then longer strings wouldn't line up.

Comment 10

[Paul Biggar]

http://hg.mozilla.org/tracemonkey/rev/a008ac5b817c

Comment 11

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/a008ac5b817c