642322 - Disco Pane issues

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P1)

Description

[Justin Scott [:fligtar]]

Just noticed some serious issues that should be fixed tomorrow:

1. On preview, RYF module isn't truncated soon enough and has an escaped entity. This appears to be a regression from prod: http://grab.by/9wcN

2. On prod, RYF images aren't showing: http://grab.by/9wcT

3. On preview and prod, the mobile block has somehow gotten too wide and covers the image: http://grab.by/9wcY

4. Please link the title of the Firefox 4 collection promo to the actual collection page.

Comment 1

[Wil Clouser [:clouserw]]

> 1. On preview, RYF module isn't truncated soon enough and has an escaped
> entity. This appears to be a regression from prod: http://grab.by/9wcN
If it saves us a "|xssafe" on our end, we should de-entitize the contents after they are pulled from the feed and before they are put in our db (see apps/discovery/cron.py) so they hit our regular escaping.

Comment 2

[krupa raj[:krupa]]

Attachment: screenshot

HTML for right single quotation mark is visible in the RYF panel.

Comment 3

[Justin Scott [:fligtar]]

I asked Dan to use the excerpt field like normal, so the truncation issues are no longer present. All the others still are though.

Comment 4

[Potch [:potch]]

taking this so it can 6.0.1.

Comment 5

[Potch [:potch]]

https://github.com/jbalogh/zamboni/compare/64658db6~1...f9824838