Closed Bug 642442 Opened 13 years ago Closed 9 years ago

Fix standalone JS build to copy run_mozilla.sh over to bin

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: sdwilsh, Unassigned)

Details

(Whiteboard: [good first bug]) 

Build automation currently has to copy run_mozilla.sh over to dist/bin for standalone spidermonkey builds like so:
https://hg.mozilla.org/build/tools/file/d52b68caf858/scripts/spidermonkey_builds/spidermonkey.sh#l98

The build system should really do this so automation doesn't have to (as well as people building standalone js).
For posterity:
[07:10]	<khuey>	sdwilsh: you can fix it, copy http://mxr.mozilla.org/mozilla-central/source/build/unix/Makefile.in#56 and build/unix/run_mozilla.sh
[07:11]	<sdwilsh>	copy it to what?
[07:11]	<khuey>	js/src/build/unix
Whiteboard: [good first bug]
It definitely works, but makefiles are far from my cup of tea. We'll let Shawn figure out if make check on Windows is working (I don't know that it uses run-mozilla.sh).
Honestly you could have stuck the file in js/src/build/unix, but just did the $(INSTALL) right from js/src/Makefile, to avoid a whole other Makefile+make invocation.
(In reply to comment #5)
> Honestly you could have stuck the file in js/src/build/unix, but just did the
> $(INSTALL) right from js/src/Makefile, to avoid a whole other Makefile+make
> invocation.

Good point. I think I'll change it to do that.
(In reply to comment #4)
> It definitely works, but makefiles are far from my cup of tea. We'll let Shawn
> figure out if make check on Windows is working (I don't know that it uses
> run-mozilla.sh).
Seems to work fine on windows.
Is this an ongoing concern, or can we close this one out?
Flags: needinfo?(paul)
Honestly, I haven't built JS in going on 4 years so I have no idea.
Flags: needinfo?(paul)
OK, who do we ask?
Somebody who builds standalone JS with any regularity? I'm willing to bet if nobody has complained since then it's fine to just close this out.
(In reply to Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) from comment #11)
> Somebody who builds standalone JS with any regularity? I'm willing to bet if
> nobody has complained since then it's fine to just close this out.

Maybe the fuzzing team?
Flags: needinfo?(gary)
I don't think we have ever needed run_mozilla.sh recently. Setting needinfo? from Steve who did some work on the js build system for Windows lately, for confirmation.
Flags: needinfo?(gary) → needinfo?(sphink)
I don't know either. The standalone build script (originally spidermonkey.sh in buildbotcustom, now autospider.sh in js/src/devtools/automation) still copies it over, but as far as I know nothing uses it anymore. I think it's still useful for xpcshell, but that's irrelevant for the JS tree.

I say we just resolve this bug and if it's ever an issue, someone can reopen or open a new one.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(sphink)
Resolution: --- → INVALID
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.