642473 - Make it possible to have a wider area for diffs

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Kadir Topal [:atopal]]

At only 40 chars the diff view is too narrow to be really usable. As soon as there are more than a few lines of changes it becomes very hard to read. Please add an option to switch to an 80 character view, or add the option to resize it manually (I guess that's way more difficult)

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: wider diff, v1

Kadir, what did you have in mind exactly? Something simple is a 100%-wide diff, and some button to toggle between the two. So you would toggle between the top and the bottom diffs in this screenshot.

The second diff is still side by side. As you can see, there is a scrollbar because otherwise it would break the layout. Alternatively you could get the left vs right diff one on top of the other. Thoughts?

Comment 2

[James Socol [:jsocol, :james]]

No answer, freezing today => pushing out.

Comment 3

[Paul Craciunoiu [:paulc]]

No answer, pushing out. Code for above screenshot is here:
https://github.com/pcraciunoiu/kitsune/compare/wider-diff

Comment 4

[Kadir Topal [:atopal]]

From my own experience translating articles, I can say that a wider text area and still having both versions side by side far outweighs the downside of a broken layout (assuming of course it just means that the text areas will stick out left and right from the centered 960px box) Having the versions on top of each other is not that useful, especially since monitors are rather wide than high, and horizontal scrollbars are a no-no.

Comment 5

[James Socol [:jsocol, :james]]

Ricky, would you mind taking a stab at this?

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/jsocol/kitsune/commit/8049a0630da24d869e4848976905e2ecba9d3753

Comment 7

[Kadir Topal [:atopal]]

Thanks, Ricky, that's really great :) can we have something similar for bug 610112 ?

Comment 8

[Rebecca Billings [:rbillings]]

Verified able to stretch size of diff windows