Closed
Bug 642584
Opened 15 years ago
Closed 15 years ago
Investigate the cost of the sampler
Categories
(Tamarin Graveyard :: Profiler, defect)
Tamarin Graveyard
Profiler
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: alexmac, Unassigned)
References
Details
Attachments
(1 file)
|
11.43 KB,
patch
|
pnkfelix
:
feedback-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_6; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.134 Safari/534.16
Build Identifier:
As an experiment I added some more runtime conditionalization to some of the hot paths in the codebase around the debugger and the sampler in particular. The VM perf tests seem to be quite small and rather noisy so I'm not sure what the accuracy of these tests is.
I thought I'd post my patch and a full perf run (from my macbook pro 2.6Ghz core2 duo ~3 years old).
The changes in performance seem like a bit of a mixed bag to me, but I'd like to get the VM team's take on what the results show and whether this patch is the right thing to do
Reproducible: Always
| Reporter | ||
Comment 1•15 years ago
|
||
| Reporter | ||
Comment 2•15 years ago
|
||
avm1 is a clean tamarin build with --enable-debugger at compile time and -Dnodebugger at runtime
avm2 is the same but with the supplied patch applied
Tamarin tests started: 2011-03-17 10:22:50.275436
Executing 460 test(s)
avm: /Users/alex/avmshell-cleandebugger -Dnodebugger version: cyclone
avm2: /Users/alex/avmshell-minimal -Dnodebugger version: cyclone
iterations: 10
avm avm2
test best avg best avg %dBst %dAvg
Metric: iterations/second
Dir: asmicro/
alloc-1 31.7 31.7 31.2 31.2 -1.6 -1.6 -
alloc-10 10.2 10.2 10.5 10.5 2.9 2.9 +
alloc-11 11.2 11.2 11.3 11.3 1.2 1.2 +
alloc-12 11.3 11.2 11.5 11.4 1.7 1.6 +
alloc-13 63.1 63.0 61.8 61.7 -2.0 -2.0 -
alloc-14 52.3 51.0 51.9 51.4 -0.7 0.9
alloc-2 15.5 15.5 15.0 15.0 -3.4 -3.3 -
alloc-3 11.9 11.8 11.4 11.4 -4.0 -4.0 -
alloc-4 37.0 37.0 37.0 37.0 0.1 0.1
alloc-5 26.7 26.6 26.2 26.1 -1.7 -2.0
alloc-6 51.6 51.6 49.7 49.7 -3.8 -3.7 -
alloc-7 27.5 27.5 28.5 28.5 3.7 3.7 +
alloc-8 10.7 10.7 11.0 11.0 2.4 2.4 +
alloc-9 10.7 10.7 11.0 10.9 2.3 2.6 +
arguments-1 638.7 638.1 638.7 638.3 0 0.0
arguments-2 362.3 361.7 358.6 357.9 -1.0 -1.1 -
arguments-3 15.7 15.7 16.0 16.0 1.5 1.4 +
arguments-4 21.9 21.9 22.8 22.8 4.2 4.2 +
array-1 2103.9 2103.0 2103.9 2103.2 0 0.0
array-2 512.5 512.1 509.5 509.3 -0.6 -0.5 -
array-pop-1 357.9 353.9 370.3 368.0 3.4 4.0 +
array-push-1 259.5 259.0 229.8 228.4 -11.5 -11.8 --
array-shift-1 117.9 116.2 122.6 121.6 4.0 4.6 +
array-slice-1 17.4 17.4 17.3 17.3 -0.7 -0.5
array-sort-1 24.2 24.2 23.6 23.4 -2.6 -3.0 -
array-sort-2 1.9 1.9 1.8 1.8 -5.9 -5.6 --
array-sort-3 18.7 18.6 19.1 19.0 2.1 2.0
array-sort-4 8.6 8.5 8.8 8.7 1.9 2.2 +
array-unshift-1 148.1 147.7 134.6 134.1 -9.1 -9.2 --
closedvar-read-1 4432.6 4425.8 4417.6 4349.6 -0.3 -1.7
closedvar-write-1 3437.6 3412.7 3606.4 3592.3 4.9 5.3 +
closedvar-write-2 3596.4 3585.6 3304.7 3239.9 -8.1 -9.6 --
do-1 3768.2 3749.2 3735.3 3726.0 -0.9 -0.6
for-1 3688.3 3686.9 3689.3 3687.0 0.0 0.0
for-2 2485.5 2485.2 2486.5 2485.6 0.0 0.0
for-3 2584.4 2583.9 2584.4 2583.7 0 -0.0
for-in-1 328.7 327.4 338.7 337.9 3.0 3.2 +
for-in-2 316.4 314.9 323.4 321.4 2.2 2.0 +
funcall-1 274.5 272.7 267.7 266.5 -2.4 -2.2 -
funcall-2 191.6 190.9 185.4 185.3 -3.2 -2.9 -
funcall-3 258.2 258.0 244.8 243.7 -5.2 -5.5 --
funcall-4 93.9 92.9 92.2 90.7 -1.8 -2.4 -
globalvar-read-1 4446.6 4442.4 4445.6 4428.3 -0.0 -0.3
globalvar-write-1 3286.7 3265.6 3061.9 3027.5 -6.8 -7.3 --
isNaN-1 3633.4 3631.6 3634.4 3632.5 0.0 0.0
isNaN-2 3690.3 3685.6 3685.3 3676.4 -0.1 -0.2
isNaN-3 3680.3 3674.8 3681.3 3676.6 0.0 0.0
lookup-array-fetch-1 631.4 630.7 635.4 635.0 0.6 0.7 +
lookup-array-in-1 1459.5 1456.4 1468.5 1462.2 0.6 0.4 +
lookup-negindex-array-1 381.9 381.1 387.6 387.4 1.5 1.6 +
lookup-negindex-array-2 324.0 323.7 333.0 332.8 2.8 2.8 +
lookup-negindex-object-1 396.8 396.7 400.2 399.7 0.9 0.7 +
lookup-negindex-object-2 376.6 376.6 375.2 375.1 -0.4 -0.4 -
lookup-object-fetch-1 666.7 665.9 668.7 668.4 0.3 0.4 +
lookup-object-in-1 1197.8 1194.7 1193.8 1189.2 -0.3 -0.5 -
number-toString-1 4.7 4.7 4.7 4.7 -0.4 -0.4
number-toString-2 48.2 48.2 47.6 47.5 -1.4 -1.3 -
oop-1 3.2 3.2 3.3 3.3 3.1 3.4 +
parseFloat-1 63.4 63.3 63.4 63.4 0.1 0.1
parseInt-1 152.2 147.7 151.7 146.0 -0.4 -1.1
regex-exec-1 40.2 40.1 43.9 43.8 9.2 9.4 ++
regex-exec-2 46.7 46.6 53.3 53.2 14.1 14.1 ++
regex-exec-3 79.9 79.8 80.5 80.4 0.7 0.8
regex-exec-4 193.2 193.1 203.6 203.3 5.4 5.3 ++
restarg-1 639.4 638.8 639.4 639.0 0 0.0
restarg-2 353.9 353.8 348.0 347.8 -1.7 -1.7 -
restarg-3 29.3 29.2 29.3 29.2 -0.1 0.3
restarg-4 21.8 21.8 22.9 22.8 4.8 4.7 +
string-casechange-1 20.1 20.1 19.7 19.7 -2.1 -2.1 -
string-casechange-2 20.2 20.1 18.5 18.5 -8.1 -8.2 --
string-charAt-1 1394.6 1393.8 1379.6 1378.9 -1.1 -1.1 -
string-charAt-2 56.9 56.8 53.1 53.1 -6.7 -6.6 --
string-charCodeAt-1 1113.9 1112.4 1082.9 1082.9 -2.8 -2.6 -
string-charCodeAt-2 1006.0 1004.9 997.0 995.3 -0.9 -1.0 -
string-charCodeAt-3 991.0 990.2 996.0 990.6 0.5 0.0
string-charCodeAt-4 1792.2 1789.3 1807.2 1802.6 0.8 0.7 +
string-charCodeAt-5 824.2 823.4 810.2 809.4 -1.7 -1.7 -
string-charCodeAt-6 1088.9 1088.8 1082.9 1082.8 -0.6 -0.6 -
string-charCodeAt-7 1799.2 1796.9 1811.2 1805.9 0.7 0.5 +
string-fromCharCode-1 245.5 245.3 243.0 241.9 -1.0 -1.4 -
string-fromCharCode-2 47.0 47.0 45.4 45.3 -3.5 -3.5 -
string-indexOf-1 187.6 187.6 180.9 180.3 -3.6 -3.9 -
string-indexOf-2 146.4 146.4 146.4 146.4 0 0.0
string-indexOf-3 67.0 66.8 67.0 66.8 0 -0.0
string-lastIndexOf-1 480.5 480.0 476.6 476.2 -0.8 -0.8 -
string-lastIndexOf-2 152.5 152.4 152.4 152.4 -0.1 -0.0
string-lastIndexOf-3 146.4 146.4 147.3 147.3 0.6 0.6
string-slice-1 82.5 82.4 82.6 82.5 0.1 0.1
string-split-1 7.4 7.4 7.5 7.5 1.4 1.3 +
string-split-2 7.4 7.4 7.5 7.5 0.7 0.7
string-substring-1 87.9 87.8 84.8 84.8 -3.5 -3.4 -
switch-1 809.2 806.0 809.4 809.0 0.0 0.4
switch-2 111.8 111.7 113.7 113.6 1.7 1.7 +
switch-3 170.5 170.4 202.6 202.4 18.8 18.7 ++
try-1 192.8 192.4 192.0 191.8 -0.4 -0.3 -
try-2 10.6 10.6 12.4 12.4 17.1 16.9 ++
try-3 37.3 37.3 37.9 37.9 1.5 1.4 +
vector-push-1 33.3 33.3 37.5 37.5 12.5 12.6 ++
while-1 3688.3 3687.6 3689.3 3688.0 0.0 0.0
Metric: time
Dir: jsbench/
Crypt 3708 3716.5 3683 3685.5 0.7 0.8 +
Euler 8826 8857.2 8579 8598.3 2.8 2.9 +
FFT 8065 8078.4 7484 7503.9 7.2 7.1 ++
HeapSort 3776 3777.1 3568 3568.8 5.5 5.5 ++
LUFact 6489 6517.9 6277 6286.2 3.3 3.6 +
Moldyn 13471 13488.9 12719 12753.7 5.6 5.5 ++
RayTracer 8647 8654.9 8079 8085.9 6.6 6.6 ++
SOR 35497 35511.5 32659 32689.6 8.0 7.9 ++
Series 10453 10470.1 10295 10309.2 1.5 1.5 +
SparseMatmult 10453 10497.7 10315 10321.7 1.3 1.7 +
Dir: jsbench/typed/
Crypt 1038 1039.2 974 975.1 6.2 6.2 ++
Euler 10430 10445.4 9821 9842.6 5.8 5.8 ++
FFT 1815 1816.7 1788 1788.8 1.5 1.5 +
HeapSort 1371 1372.2 1371 1371.7 0 0.0
LUFact 1399 1399.5 1430 1430.6 -2.2 -2.2 -
Moldyn 5046 5051.3 4871 4880.5 3.5 3.4 +
RayTracer 1496 1496.4 1493 1493.7 0.2 0.2 +
SOR 5191 5194.6 5102 5104.5 1.7 1.7 +
Series 9117 9124.5 8652 8657.9 5.1 5.1 ++
SparseMatmult 2590 2605.4 2547 2549.5 1.7 2.1 +
Metric: iterations/second
Dir: jsmicro/
alloc-1 30.2 30.2 30.1 30.1 -0.4 -0.3
alloc-10 9.9 9.9 10.2 10.1 3.2 2.8 +
alloc-11 9.7 9.7 10.0 10.0 3.5 3.4
alloc-12 9.7 9.7 10.1 10.1 3.8 3.8 +
alloc-13 56.4 56.3 55.4 55.4 -1.8 -1.7 -
alloc-14 47.9 47.7 47.4 47.1 -1.1 -1.2 -
alloc-2 15.4 15.4 14.7 14.7 -4.8 -4.5 -
alloc-3 11.7 11.6 11.4 11.3 -2.6 -2.4 -
alloc-4 35.3 35.3 35.7 35.7 1.3 1.2 +
alloc-5 25.2 25.2 25.3 25.2 0.7 0.1
alloc-6 46.7 46.6 45.0 44.9 -3.8 -3.6 -
alloc-7 28.2 28.2 28.9 28.9 2.5 2.5 +
alloc-8 10.5 10.4 10.7 10.6 2.4 2.2 +
alloc-9 10.5 10.4 10.7 10.7 2.2 2.3 +
arguments-1 132.1 131.9 134.6 134.3 1.9 1.8 +
arguments-2 87.4 86.9 89.5 89.1 2.4 2.5 +
arguments-3 13.6 13.6 14.1 14.1 4.0 4.0 +
array-1 345.0 344.8 362.9 362.0 5.2 5.0 ++
array-2 243.0 242.8 247.5 247.4 1.8 1.9 +
array-pop-1 57.7 57.3 52.5 52.1 -8.9 -9.0 --
array-push-1 40.1 40.1 41.5 41.4 3.3 3.4 +
array-shift-1 45.8 45.5 43.4 43.3 -5.1 -5.0 --
array-slice-1 14.2 14.2 14.2 14.2 0.3 -0.0
array-sort-1 22.5 22.4 21.8 21.8 -3.0 -3.0 -
array-sort-2 1.9 1.9 1.8 1.8 -5.7 -6.1 --
array-sort-3 18.7 18.6 19.1 19.0 2.1 2.0
array-sort-4 6.3 6.3 8.7 8.7 37.8 37.1 ++
array-unshift-1 18.8 18.8 17.7 17.7 -5.5 -5.5 --
closedvar-read-1 565.9 565.5 565.9 563.3 0 -0.4
closedvar-write-1 403.2 402.0 393.2 392.8 -2.5 -2.3 -
closedvar-write-2 401.6 400.9 395.6 394.7 -1.5 -1.6 -
do-1 590.4 589.7 589.4 589.2 -0.2 -0.1 -
for-1 565.9 565.7 567.9 567.5 0.4 0.3 +
for-2 155.4 154.9 168.7 168.5 8.5 8.8 ++
for-3 112.2 112.0 120.4 120.0 7.3 7.2 ++
for-in-1 251.7 250.6 254.5 253.8 1.1 1.3 +
for-in-2 256.2 254.9 254.0 253.2 -0.9 -0.7 -
funcall-1 182.1 181.9 177.6 176.8 -2.4 -2.8 -
funcall-2 175.6 175.6 179.3 179.2 2.1 2.0 +
funcall-3 179.8 179.8 176.3 176.2 -2.0 -2.0 -
funcall-4 1155.8 1154.7 1176.8 1175.6 1.8 1.8 +
globalvar-read-1 563.4 563.0 568.9 568.4 1.0 1.0 +
globalvar-write-1 402.6 401.8 395.8 394.6 -1.7 -1.8 -
isNaN-1 503.0 502.9 504.0 503.5 0.2 0.1 +
lookup-array-fetch-1 552.4 552.1 546.5 546.0 -1.1 -1.1 -
lookup-array-in-1 917.1 916.2 914.1 913.6 -0.3 -0.3 -
lookup-object-fetch-1 583.4 581.6 573.4 572.2 -1.7 -1.6 -
lookup-object-in-1 822.2 821.7 820.2 819.0 -0.2 -0.3 -
number-toString-1 4.6 4.6 4.7 4.7 1.6 1.6 +
number-toString-2 45.6 45.6 42.7 42.6 -6.5 -6.5 --
oop-1 3.3 3.3 3.2 3.2 -2.5 -2.6 -
parseFloat-1 44.3 44.3 46.1 46.0 4.0 4.0 +
parseInt-1 105.4 102.6 104.1 101.3 -1.2 -1.3
regex-exec-1 33.8 33.7 37.0 36.9 9.6 9.6 ++
regex-exec-2 40.2 40.0 48.1 48.0 19.5 20.1 ++
regex-exec-3 70.6 70.5 70.9 70.9 0.5 0.5
regex-exec-4 156.7 156.7 162.8 162.7 3.9 3.9 +
string-casechange-1 13.7 13.7 13.4 13.4 -2.2 -2.3 -
string-casechange-2 13.6 13.6 13.7 13.7 1.3 1.3 +
string-charAt-1 78.1 78.0 80.3 80.3 2.8 2.9 +
string-charAt-2 31.6 31.6 32.5 32.5 2.9 2.9 +
string-charCodeAt-1 75.2 75.2 77.8 77.8 3.5 3.3 +
string-charCodeAt-2 74.3 74.0 76.8 76.6 3.5 3.5 +
string-fromCharCode-1 64.2 64.1 66.3 66.2 3.2 3.2 +
string-fromCharCode-2 30.4 30.4 29.9 29.9 -1.8 -1.8 -
string-fromCharCode-3 50.0 49.9 49.0 49.0 -1.9 -1.8 -
string-fromCharCode-4 51.2 51.2 50.2 50.2 -1.8 -1.9 -
string-indexOf-1 66.9 66.9 66.0 65.9 -1.4 -1.4 -
string-indexOf-2 50.8 50.8 50.3 50.2 -1.1 -1.3 -
string-indexOf-3 34.1 33.9 31.3 31.2 -8.2 -8.0 --
string-lastIndexOf-1 67.6 67.5 68.4 68.3 1.2 1.1 +
string-lastIndexOf-2 51.6 51.6 51.8 51.6 0.4 -0.0
string-lastIndexOf-3 47.7 47.7 50.8 50.8 6.5 6.6 ++
string-slice-1 36.3 36.3 37.3 37.3 2.6 2.6 +
string-split-1 6.8 6.8 6.8 6.8 -0.8 -0.7
string-split-2 6.9 6.9 6.8 6.8 -1.7 -2.0 -
string-substring-1 37.8 37.8 39.2 39.1 3.5 3.4 +
switch-1 96.0 95.8 91.5 91.5 -4.7 -4.5 -
switch-2 54.0 54.0 53.3 53.3 -1.3 -1.2 -
switch-3 69.1 69.0 66.9 66.7 -3.2 -3.2 -
try-1 151.2 151.0 151.2 151.1 0 0.1
try-2 10.3 10.3 12.3 12.2 18.7 18.5 ++
try-3 31.2 31.2 31.2 31.2 0 -0.0
while-1 565.9 565.5 567.9 567.5 0.4 0.3 +
Metric: time
Dir: language/describetype/
desctypeperf 664 664.4 665 665.2 -0.2 -0.1 -
Dir: language/e4x/
addingToXMLList 19 19.1 18 18.9 5.3 1.0 +
appendChildAndString 54 54 54 54.8 0 -1.5
concatenatingStringsFromE4X 8 8.9 8 8.8 0 1.1
simpleStringConcatenation 2 2 2 2 0 0
usingAppendChildAndE4X 58 58 58 58.4 0 -0.7
Dir: language/string/
append_concat 109 109.6 110 110.9 -0.9 -1.2 -
append_equal_plus 94 95.1 95 95.1 -1.1 0 -
append_plus_equal 95 95.3 94 95.1 1.1 0.2 +
charAt 196 197.3 186 186.7 5.1 5.4 ++
charCodeAt 217 218.6 218 219.6 -0.5 -0.5
indexOf 600 600 599 599.7 0.2 0.0 +
lastIndexOf 206 206.9 206 206.7 0 0.1
replace 531 533.2 506 507.4 4.7 4.8 +
replace2 1250 1253.4 1244 1244.7 0.5 0.7
search 42 42.5 42 42.2 0 0.7
slice 363 363.8 364 366 -0.3 -0.6
split 431 432.9 459 479.3 -6.5 -10.7 --
static_ascii_array_100 230 230.5 227 227.1 1.3 1.5 +
static_ascii_array_50 213 213.7 209 210.1 1.9 1.7 +
static_latin1_array_100 441 443.9 436 438 1.1 1.3 +
static_latin1_array_50 221 223 218 219.2 1.4 1.7 +
substr 267 267.7 275 276.4 -3.0 -3.2 -
substring 258 258.2 270 271.1 -4.7 -5.0 -
Dir: language/string/typed/
append_concat 101 102.4 101 101.7 0 0.7
append_equal_plus 90 90.3 90 90.2 0 0.1
append_plus_equal 90 90.2 89 89.9 1.1 0.3
charAt 11 11 10 10.8 9.1 1.8 ++
charCodeAt 10 10.9 10 10.9 0 0
indexOf 596 599.6 600 600 -0.7 -0.1 -
lastIndexOf 206 206.7 206 206.7 0 0
replace 528 529.9 506 506.8 4.2 4.4 +
replace2 1230 1230.9 1253 1253.9 -1.9 -1.9 -
search 42 42.5 42 42.1 0 0.9
slice 231 231.4 230 230 0.4 0.6 +
split 424 424.5 411 413.2 3.1 2.7 +
substr 176 176.1 181 181.1 -2.8 -2.8 -
substring 171 171.8 175 175.8 -2.3 -2.3 -
Dir: misc/
boids 2221 2223.7 2160 2161.1 2.7 2.8 +
boidshack 490 491.4 476 477 2.9 2.9 +
gameoflife 1541 1542.4 1537 1538.6 0.3 0.2 +
primes 5267 5273.7 5266 5274 0.0 -0.0
Dir: mmgc/
gcbench 3551 3555.8 3414 3417.9 3.9 3.9 +
ofib-rc 353 354.9 349 350.9 1.1 1.1 +
ofib 1336 1451.9 1318 1422.4 1.3 2.0
sfib 479 479.9 476 476.4 0.6 0.7 +
Dir: scimark/
FFT 2433 2436.8 2281 2283.1 6.2 6.3 ++
LU 3425 3426.9 3308 3310.3 3.4 3.4 +
MonteCarlo 3050 3052.8 2907 2909 4.7 4.7 +
SOR 2661 2665 2431 2435.4 8.6 8.6 ++
SparseCompRow 108 108.1 105 105.8 2.8 2.1 +
Dir: sunspider/
access-binary-trees 42 42.3 41 41.3 2.4 2.4 +
access-fannkuch 80 80.3 80 80.5 0 -0.2
access-nbody 92 92 88 88.1 4.3 4.2 +
access-nsieve 26 26.8 27 27.5 -3.8 -2.6 -
bitops-3bit-bits-in-byte 11 11.8 12 12 -9.1 -1.7 --
bitops-bits-in-byte 32 32.3 32 32.5 0 -0.6
bitops-bitwise-and 281 282.9 279 279.6 0.7 1.2 +
bitops-nsieve-bits 44 44.2 43 43.8 2.3 0.9 +
controlflow-recursive 18 18.4 18 18.9 0 -2.7
crypto-aes 43 43.9 43 43.2 0 1.6
crypto-md5 21 21.6 20 20.7 4.8 4.2 +
crypto-sha1 21 21.9 21 21 0 4.1
date-format-tofte 274 289.2 272 285.9 0.7 1.1
math-cordic 58 58.3 55 55.9 5.2 4.1 ++
math-partial-sums 270 270.8 265 266.1 1.9 1.7 +
math-spectral-norm 34 34.5 33 33 2.9 4.3 +
s3d-cube 80 80.3 74 74.5 7.5 7.2 ++
s3d-morph 45 45 44 44.1 2.2 2.0 +
s3d-raytrace 92 92.7 87 88.3 5.4 4.7 ++
string-fasta 91 91.9 90 90.9 1.1 1.1 +
string-unpack-code 213 213.8 213 214.4 0 -0.3
string-validate-input 57 57.1 57 57.8 0 -1.2
Dir: sunspider/as3/
access-binary-trees 11 11.8 11 11.9 0 -0.8
access-fannkuch 44 44.9 43 43.3 2.3 3.6 +
access-nbody 6 6.3 6 6.3 0 0
access-nsieve 14 14.3 14 14.9 0 -4.2
bitops-3bit-bits-in-byte 6 6.7 6 6.6 0 1.5
bitops-bits-in-byte 9 9.3 9 9.1 0 2.2
bitops-bitwise-and 1 1.7 1 1.7 0 0
bitops-nsieve-bits 28 28.1 27 27.4 3.6 2.5 +
controlflow-recursive 4 4.6 4 4.7 0 -2.2
crypto-aes 32 32.4 32 32.2 0 0.6
crypto-md5 27 27.7 26 26.8 3.7 3.2 +
crypto-sha1 21 21 20 20 4.8 4.8 +
date-format-tofte 263 279.7 262 276.8 0.4 1.0
math-cordic 16 16.3 15 15.4 6.2 5.5 +
math-partial-sums 86 86.1 85 85.1 1.2 1.2 +
math-spectral-norm 6 6.2 6 6 0 3.2
s3d-cube 21 21.9 21 21.5 0 1.8
s3d-morph 33 33.2 31 31.1 6.1 6.3 ++
s3d-raytrace 36 36.4 35 35.3 2.8 3.0 +
string-fasta 44 44.6 43 43.6 2.3 2.2 +
string-unpack-code 209 210.2 210 210.8 -0.5 -0.3
string-validate-input 44 44.7 43 43.7 2.3 2.2 +
Dir: sunspider/as3vector/
access-fannkuch 23 23.8 23 23.7 0 0.4
access-nbody 6 6 6 6.2 0 -3.3
access-nsieve 12 12 11 11.6 8.3 3.3 +
bitops-nsieve-bits 8 8.3 8 8.3 0 0
math-cordic 15 15 14 14 6.7 6.7 ++
math-spectral-norm 19 19 17 17.4 10.5 8.4 ++
s3d-cube 18 18.3 18 18 0 1.6
s3d-morph 16 16.8 17 17.6 -6.2 -4.8 -
string-fasta 49 49 46 46.9 6.1 4.3 ++
string-validate-input 45 45.8 46 46.1 -2.2 -0.7 -
Dir: sunspider-0.9.1/js/
access-binary-trees 41 41.5 41 41 0 1.2
access-fannkuch 80 81.1 78 78.4 2.5 3.3 +
access-nbody 88 88.9 86 90.6 2.3 -1.9
access-nsieve 27 27 27 27.5 0 -1.9
bitops-3bit-bits-in-byte 10 10.4 10 10.4 0 0
bitops-bits-in-byte 32 32.3 32 32.7 0 -1.2
bitops-bitwise-and 279 279.2 291 291.3 -4.3 -4.3 -
bitops-nsieve-bits 42 42.8 43 43.5 -2.4 -1.6 -
controlflow-recursive 18 18.1 18 18.2 0 -0.6
crypto-aes 38 38.5 37 37.3 2.6 3.1 +
crypto-md5 19 19.6 18 18.6 5.3 5.1 +
crypto-sha1 20 20.3 19 19.4 5 4.4 +
math-cordic 57 57.1 54 54.6 5.3 4.4 ++
math-partial-sums 263 263.8 257 258.8 2.3 1.9 +
math-spectral-norm 34 34.5 33 33 2.9 4.3 +
regexp-dna 1335 1359.7 1295 1315.8 3.0 3.2 +
s3d-cube 74 74.8 68 68.6 8.1 8.3 ++
s3d-morph 67 67.9 66 66.1 1.5 2.7 +
s3d-raytrace 84 84.6 81 81.6 3.6 3.5 +
string-fasta 65 65.1 64 64.6 1.5 0.8 +
string-unpack-code 5627 5651.4 5535 5631.9 1.6 0.3 +
string-validate-input 55 55 54 54.6 1.8 0.7 +
Dir: sunspider-0.9.1/typed/
access-binary-trees 10 10.3 10 10.4 0 -1.0
access-fannkuch 49 49.7 49 49.4 0 0.6
access-nbody 4 4.1 4 4 0 2.4
access-nsieve 12 12.5 12 12.3 0 1.6
bitops-3bit-bits-in-byte 6 6 6 6 0 0
bitops-bits-in-byte 8 8.6 8 8.3 0 3.5
bitops-bitwise-and 1 1.4 1 1.6 0 -14.3
bitops-nsieve-bits 27 27.5 27 27.6 0 -0.4
controlflow-recursive 4 4.2 4 4.2 0 0
crypto-aes 28 28.2 27 27.6 3.6 2.1 +
crypto-md5 3 3.8 3 3.7 0 2.6
crypto-sha1 4 4.9 5 5 -25 -2.0 --
math-cordic 15 15.7 14 14.2 6.7 9.6 +
math-partial-sums 11 11.4 11 11.6 0 -1.8
math-spectral-norm 8 8.2 8 8.3 0 -1.2
regexp-dna 1317 1332.3 1248 1274.1 5.2 4.4 ++
s3d-cube 19 19.2 18 18.8 5.3 2.1 +
s3d-morph 54 55.4 54 55.1 0 0.5
s3d-raytrace 11 11 10 10.4 9.1 5.5 +
string-fasta 36 36.2 35 35.9 2.8 0.8 +
string-unpack-code 5600 5666.7 5601 5684.3 -0.0 -0.3
string-validate-input 35 35.7 34 34.8 2.9 2.5 +
Metric: v8 custom v8 normalized metric (hardcoded in the test)
Dir: v8/
crypto 414 413.8 430 429.2 3.9 3.7 +
deltablue 1350 1346.6 1354 1352.5 0.3 0.4 +
earley-boyer 841 837.9 860 851.9 2.3 1.7 +
raytrace 2368 2366.2 2476 2472 4.6 4.5 +
richards 917 912.7 918 916.2 0.1 0.4
Dir: v8/typed/
crypto 454 453.3 462 461.3 1.8 1.8 +
deltablue 2171 2167.3 2230 2226 2.7 2.7 +
earley-boyer 842 833 865 856.5 2.7 2.8 +
raytrace 5054 5047.5 5213 5208.9 3.1 3.2 +
richards 1777 1775.3 1777 1775.9 0 0.0
Dir: v8.5/js/
crypto 379 379 390 389.4 2.9 2.7 +
deltablue 277 276.1 281 280.3 1.4 1.5 +
earley-boyer 844 839.6 857 849.1 1.5 1.1 +
raytrace 496 495.1 515 512.8 3.8 3.6 +
regexp 61.7 61.5 63.4 63.0 2.8 2.4 +
richards 226 226 227 227 0.4 0.4
splay 659 654.1 668 659.5 1.4 0.8
Dir: v8.5/optimized/
crypto 3146 3140.5 3248 3237.1 3.2 3.1 +
deltablue 2802 2799.2 2873 2869.9 2.5 2.5 +
earley-boyer 847 841.5 863 860.1 1.9 2.2 +
raytrace 6014 6009.8 6187 6181.6 2.9 2.9 +
regexp 62.1 62.0 64.2 64 3.4 3.3 +
richards 3236 3222.5 3134 3132.2 -3.2 -2.8 -
splay 4221 4215.7 4600 4394.6 9.0 4.2 ++
Dir: v8.5/typed/
crypto 2208 2205.5 2299 2294.3 4.1 4.0 +
deltablue 2885 2880.2 2906 2902.7 0.7 0.8 +
earley-boyer 846 841.1 865 859 2.2 2.1 +
raytrace 5934 5930.4 6193 6187.6 4.4 4.3 +
regexp 62.2 62.1 64.2 64.0 3.2 3.0 +
richards 3227 3206.6 3134 3133.6 -2.9 -2.3 -
splay 842 836.7 856 824.7 1.7 -1.4
Dir: v8.5/untyped/
crypto 421 420.6 432 431.5 2.6 2.6 +
deltablue 1374 1372.2 1392 1390.1 1.3 1.3 +
earley-boyer 844 839.2 857 851.2 1.5 1.4 +
raytrace 2518 2514 2618 2613.6 4.0 4.0 +
regexp 62 61.6 63.6 63.2 2.6 2.6 +
richards 330 328.7 324 323 -1.8 -1.7 -
splay 794 792.5 790 788.2 -0.5 -0.5 -
| Reporter | ||
Updated•15 years ago
|
Blocks: rm_DEBUGGER_tracker
Updated•15 years ago
|
Attachment #520016 -
Flags: feedback?(fklockii)
Comment 3•15 years ago
|
||
Comment on attachment 520016 [details] [diff] [review]
extra runtime conditionalisation
sorry I overlooked this until now.
I probably can't review it until Wednesday or Thursday.
Comment 4•15 years ago
|
||
Comment on attachment 520016 [details] [diff] [review]
extra runtime conditionalisation
This change does not make sense:
@@ -3473,16 +3473,15 @@
AvmAssert(deletedCount >= 0);
}
-#ifdef DEBUGGER
- DRC(Stringp) *oldStrings = strings;
-#endif
-
other = newStringLatin1(s, len);
#ifdef DEBUGGER
- // re-find if String ctor caused rehash
- if(strings != oldStrings)
- i = findStringLatin1(s, len);
+ if(_debugger) {
+ DRC(Stringp) *oldStrings = strings;
+ // re-find if String ctor caused rehash
+ if(strings != oldStrings)
+ i = findStringLatin1(s, len);
+ }
#endif
strings[i] = other;
stringCount++;
Consider the following: why did the old code have the conditional test
(string != oldStrings), which presumably would never resolve to true
after incorporating your patch? Answer: the point of this code is to
fix-up the slot index in response to a rehash from the newStringLatin1
call (ie the "String ctor" in the comment); grabbing oldStrings after
the call is too late.
(One might reasonably wonder how this code possibly works if when
!DEBUGGER; from past discussions with Tommy, I believe the underlying
invariant is that when !DEBUGGER, the String ctor's never rehash. But
we really should be asserting that...)
There are two other changes to AvmCore.cpp in your patch that look
similar, and both of them seem to have the same problem.
Attachment #520016 -
Flags: feedback?(fklockii) → feedback-
Comment 5•15 years ago
|
||
(In reply to comment #4)
> (One might reasonably wonder how this code possibly works if when
> !DEBUGGER; from past discussions with Tommy, I believe the underlying
> invariant is that when !DEBUGGER, the String ctor's never rehash. But
> we really should be asserting that...)
We should especially be asserting it because while it may hold today, it is a fragile invariant. The AvmCore presweep handler may potentially rehash the namespaces table, and its not crazy to consider having the presweep handler also rehash the strings table.
Better still may be to just get rid of the DEBUGGER preprocessor conditionals around the code here. I think that would solve Alex's problem, and I am having a hard time believing that the extra computation introduced is significant.
Comment 6•15 years ago
|
||
(In reply to comment #5)
> (In reply to comment #4)
> > (One might reasonably wonder how this code possibly works if when
> > !DEBUGGER; from past discussions with Tommy, I believe the underlying
> > invariant is that when !DEBUGGER, the String ctor's never rehash. But
> > we really should be asserting that...)
>
> We should especially be asserting it because while it may hold today, it is a
> fragile invariant. The AvmCore presweep handler may potentially rehash the
> namespaces table, and its not crazy to consider having the presweep handler
> also rehash the strings table.
>
> Better still may be to just get rid of the DEBUGGER preprocessor conditionals
> around the code here. I think that would solve Alex's problem, and I am having
> a hard time believing that the extra computation introduced is significant.
Moving this side-task to Bug 647696.
| Reporter | ||
Comment 7•15 years ago
|
||
I suspected something like that was the case with the explicit DRC's, I'll remove that change from the patch, it was unlikely to be the cause of much of the performance impact anyway.
What about the changes to the GC, do those seem reasonable?
Comment 8•15 years ago
|
||
(In reply to comment #7)
> I suspected something like that was the case with the explicit DRC's, I'll
> remove that change from the patch, it was unlikely to be the cause of much of
> the performance impact anyway.
>
> What about the changes to the GC, do those seem reasonable?
Yeah, I think so. The GetAttachedSampler calls should boil away to a memory dereference, so it seems relatively safe to me.
I'm assuming the Exception.cpp changes are not on a hot-path. I'm not an expert in that code, but those changes seem plausible as well.
Marking experiment as resolved/fixed. Reopen if necessary.
Severity: normal → minor
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Component: Debugger → Profiler
Flags: flashplayer-qrb+
Flags: flashplayer-injection-
Flags: flashplayer-bug-
QA Contact: debugger → profiler
Resolution: --- → FIXED
Target Milestone: --- → Future
You need to log in
before you can comment on or make changes to this bug.
Description
•