Clean up the drag & drop caret on the editor correctly when the mouse leaves the editable field

RESOLVED FIXED in mozilla5

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla5
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

8 years ago
Our current caret cleanup code has two problems.  One of them is that we don't clean up the caret correctly on dragexit (the same way that we do on drop), and the second problem is that we cache the created caret, which is unnecessary, and could probably cause us to use a stale caret object if the presshell dies, for example.

I have a patch which fixes both of these issues.
Assignee

Comment 1

8 years ago
Posted patch Patch (v1) (obsolete) — Splinter Review
Attachment #520019 - Flags: review?(roc)
Blocks: 638394
Assignee

Comment 2

8 years ago
Posted patch Patch (v2)Splinter Review
Let's clean this up even more.  The caret itself tracks its drawn status, so maintaining it in nsEditorEventListener is both error prone and useless, so let's get rid of mCaretDrawn altogether.
Attachment #520019 - Attachment is obsolete: true
Attachment #520046 - Flags: review?(roc)
Assignee

Updated

8 years ago
Depends on: post2.0
Assignee

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/bf031c2743d5
Status: NEW → RESOLVED
Last Resolved: 8 years ago
No longer depends on: post2.0
Resolution: --- → FIXED
Whiteboard: [post-2.0]
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.