64260 - NSS users should not include cdbhdl.h.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Wan-Teh Chang]

Some NSS users have had to include the
internal NSS header cdbhdl.h so that they
can allocate a CERTCertDBHandle structure
and pass its address to the cert database
open functions such as CERT_OpenCertDB(),
CERT_OpenCertDBFilename(), and
CERT_OpenVolatileCertDB().

The reason why these NSS users have to call
the cert db open functions directly is that 
the preferred method of using NSS_Init()
doesn't support the naming convention in use
by these NSS users.  Two possible solutions are:
1) Change the cert db open calls to allocate and
return the handle (as is done in the key db interface) -or-
2) Add calls to similar to NSS_Init() that allow the
NSS users to use the current naming convention without
making direct calls to the cert db open interface.

This issue must be resolved before we release
NSS 3.2 Beta.

Comment 1

[Wan-Teh Chang]

Turns out that we have previously agreed to implement
solution #2.

Comment 2

[Wan-Teh Chang]

Bob has written the new NSS_Initialize() function.
I think we can mark this bug fixed.

Comment 3

[Wan-Teh Chang]

*** Bug 56330 has been marked as a duplicate of this bug. ***

Comment 4

[Robert Relyea]

Attachment: remove depricated header function

Comment 5

[Robert Relyea]

Here are the 'last' of the cmd files which included the header (dbck.c was not
changed because it isn't compiled, but is an internal tool that does need this
private header).

Comment 6

[Wan-Teh Chang]

The patch is good.

Bob, should we move cdbhdl.h from EXPORTS to PRIVATE_EXPORTS?
Does any of our client (such as PSM or JSS) need it?

Comment 7

[Wan-Teh Chang]

Do we need to worry about instinit and newuser?

Comment 8

[Jamie Nicolson]

JSS still uses this header file, but we can still get at it if it is a 
PRIVATE_EXPORT.

Comment 9

[Robert Relyea]

Attachment: remove cdbhdl.h from instinit and newuser

Comment 10

[Wan-Teh Chang]

This patch is good.

Comment 11

[Robert Relyea]

Attachment: Final piece, move cdbhdl.h to the private exports list.

Comment 12

[Wan-Teh Chang]

Amen.

Comment 13

[Robert Relyea]

cdbhdl.h is now on the private exports list.