642648 - Test plan and harness

Status: RESOLVED FIXED

(Cloud Services :: Share: Firefox Client, defect)

Comment 1

[Philipp von Weitershausen [:philikon]]

We don't really need unit (=xpcshell-tests) tests since pretty much all the add-on code needs XUL window stuff.

If F1 was integrated into m-c, we'd be doing mochitests, otherwise we could do mozmill tests (they seem much easier to set up outside of the m-c tree). So this is blocked on the decision whether we'll continue as an add-on or not.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #1)
> We don't really need unit (=xpcshell-tests) tests since pretty much all the
> add-on code needs XUL window stuff.
> 
> If F1 was integrated into m-c, we'd be doing mochitests, otherwise we could do
> mozmill tests (they seem much easier to set up outside of the m-c tree). So
> this is blocked on the decision whether we'll continue as an add-on or not.

Since we have a decision to integrate, it seems like we'll be doing mochitests.

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to comment #2)
> Since we have a decision to integrate, it seems like we'll be doing mochitests.

Correct. I'm writing some as we speak.

Comment 4

[Philipp von Weitershausen [:philikon]]

Landed a first simple mochitest in https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/482128d9c887. More to come.

Comment 5

[Philipp von Weitershausen [:philikon]]

Factored out some common code into head.js in https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/a01354a1b378

Comment 6

[Philipp von Weitershausen [:philikon]]

Improved test sanity and reliability by having the first test in line load the panel. Then subsequent tests can rely on it being loaded. Also serves as a placeholder for bug 642671's tests: https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/36f06378ee86

Comment 7

[Philipp von Weitershausen [:philikon]]

Some more browser test refactoring: https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/0ace8e99df5d

I declare this bug resolved since we have quite a few tests going now. That doesn't mean we have all the tests we need (we're still lacking tests for several post messages), it just means I that we've figured out how to write tests and have a test harness :)