Closed Bug 642755 Opened 9 years ago Closed 9 years ago

DTD comment compression breaks localizations, at least Japanese


(Firefox for Android Graveyard :: General, defect, blocker)

Not set



Tracking Status
fennec 2.0+ ---


(Reporter: Pike, Assigned: mfinkle)



(Whiteboard: [has patch][has review])


(5 files)

I have no idea why the chrome/ja/locale/ja/browser/browser.dtd file in the android multi locale build would be what it is.

Can you figure out what's where?

I don't see anything that'd make me blame a wrong revision or l10n merge, I stabbed around that a bit.
diff against all two letter locales against their shipping revisions in l10n-central.

Seems that all comments get removed, and for this file, japanese has comments inline which removes the complete line including the entity.

No idea what impact that has beyond that.
Moving over to Fennec, this is not a releng problem.

This may impact other locales, including en-US if I read Gerv right on irc.

Whether the impacted code actually gets used is a different question.
Component: Release Engineering → General
Product: → Fennec
QA Contact: release → general
Summary: Investigate what's in Japanese Fennec 4 RC → DTD comment compression breaks localizations, at least Japanese
Version: other → Trunk
tracking-fennec: --- → ?
Attached patch Patch v.1Splinter Review
Here's the diff which results after running

find . -name "*.dtd" -exec perl -p -i -e 's/(<!ENTITY.*)<!--.*-->/$1/' {} \;


hg clone

276 occurrences of a comment following an entity.

Attached file Affected string list
Here are all the affected strings, across the locales listed here:

DTD comments are tricky to strip, so let's stop doing it for now. Properties files are line based comments and should be fine to strip using the existing code.
Assignee: nobody → mark.finkle
Attachment #520186 - Flags: review?(blassey.bugs)
Comment on attachment 520186 [details] [diff] [review]
patch to remove the comment stripping from DTD

Looks good to me, feedback+ and thanks.
Attachment #520186 - Flags: feedback+
tracking-fennec: ? → 2.0+
Attachment #520186 - Flags: review?(blassey.bugs) → review+
Blocks: 634647, 608412
Whiteboard: [has patch][has review]
verified FIXED on build:
    Mozilla/5.0 (Android; Linux armv7l; rv:2.1) Gecko/20110318 Firefox/4.0b13pre Fennec/4.0 ID:20110318114419
You need to log in before you can comment on or make changes to this bug.