DTD comment compression breaks localizations, at least Japanese

VERIFIED FIXED

Status

Firefox for Android Graveyard
General
--
blocker
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Pike, Assigned: mfinkle)

Tracking

Dependency tree / graph

Details

(Whiteboard: [has patch][has review])

Attachments

(5 attachments)

I have no idea why the chrome/ja/locale/ja/browser/browser.dtd file in the android multi locale build would be what it is.

Can you figure out what's where?

I don't see anything that'd make me blame a wrong revision or l10n merge, I stabbed around that a bit.
(Reporter)

Comment 1

7 years ago
Created attachment 520174 [details] [diff] [review]
diff between apk and source revision.
(Reporter)

Comment 2

7 years ago
Created attachment 520179 [details] [diff] [review]
browser.dtd diff of all two-letter locales

diff against all two letter locales against their shipping revisions in l10n-central.

Seems that all comments get removed, and for this file, japanese has comments inline which removes the complete line including the entity.

No idea what impact that has beyond that.
(Reporter)

Comment 3

7 years ago
Moving over to Fennec, this is not a releng problem.

This may impact other locales, including en-US if I read Gerv right on irc.

Whether the impacted code actually gets used is a different question.
Component: Release Engineering → General
Product: mozilla.org → Fennec
QA Contact: release → general
Summary: Investigate what's in Japanese Fennec 4 RC → DTD comment compression breaks localizations, at least Japanese
Version: other → Trunk
(Reporter)

Updated

7 years ago
tracking-fennec: --- → ?
Created attachment 520182 [details] [diff] [review]
Patch v.1

Here's the diff which results after running

find . -name "*.dtd" -exec perl -p -i -e 's/(<!ENTITY.*)<!--.*-->/$1/' {} \;

over

hg clone http://hg.mozilla.org/releases/l10n-mozilla-2.0/ja

276 occurrences of a comment following an entity.

Gerv
Created attachment 520184 [details]
Affected string list

Here are all the affected strings, across the locales listed here:
http://mxr.mozilla.org/mobile-browser/source/locales/maemo-locales

Gerv
Created attachment 520186 [details] [diff] [review]
patch to remove the comment stripping from DTD

DTD comments are tricky to strip, so let's stop doing it for now. Properties files are line based comments and should be fine to strip using the existing code.
Assignee: nobody → mark.finkle
Attachment #520186 - Flags: review?(blassey.bugs)
(Reporter)

Comment 8

7 years ago
Comment on attachment 520186 [details] [diff] [review]
patch to remove the comment stripping from DTD

Looks good to me, feedback+ and thanks.
Attachment #520186 - Flags: feedback+
(Assignee)

Updated

7 years ago
tracking-fennec: ? → 2.0+
Attachment #520186 - Flags: review?(blassey.bugs) → review+
Blocks: 634647, 608412
Whiteboard: [has patch][has review]
verified FIXED on build:
    Mozilla/5.0 (Android; Linux armv7l; rv:2.1) Gecko/20110318 Firefox/4.0b13pre Fennec/4.0 ID:20110318114419
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.