Closed
Bug 642755
Opened 13 years ago
Closed 13 years ago
DTD comment compression breaks localizations, at least Japanese
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(fennec2.0+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0+ | --- |
People
(Reporter: Pike, Assigned: mfinkle)
References
Details
(Whiteboard: [has patch][has review])
Attachments
(5 files)
2.01 KB,
patch
|
Details | Diff | Splinter Review | |
8.22 KB,
patch
|
Details | Diff | Splinter Review | |
219.57 KB,
patch
|
Details | Diff | Splinter Review | |
56.15 KB,
text/plain
|
Details | |
820 bytes,
patch
|
blassey
:
review+
Pike
:
feedback+
|
Details | Diff | Splinter Review |
I have no idea why the chrome/ja/locale/ja/browser/browser.dtd file in the android multi locale build would be what it is. Can you figure out what's where? I don't see anything that'd make me blame a wrong revision or l10n merge, I stabbed around that a bit.
Reporter | ||
Comment 1•13 years ago
|
||
Reporter | ||
Comment 2•13 years ago
|
||
diff against all two letter locales against their shipping revisions in l10n-central. Seems that all comments get removed, and for this file, japanese has comments inline which removes the complete line including the entity. No idea what impact that has beyond that.
Reporter | ||
Comment 3•13 years ago
|
||
Moving over to Fennec, this is not a releng problem. This may impact other locales, including en-US if I read Gerv right on irc. Whether the impacted code actually gets used is a different question.
Component: Release Engineering → General
Product: mozilla.org → Fennec
QA Contact: release → general
Summary: Investigate what's in Japanese Fennec 4 RC → DTD comment compression breaks localizations, at least Japanese
Version: other → Trunk
Reporter | ||
Updated•13 years ago
|
tracking-fennec: --- → ?
Reporter | ||
Comment 4•13 years ago
|
||
The strip code is in http://mxr.mozilla.org/mobile-browser/source/installer/Makefile.in#95
Comment 5•13 years ago
|
||
Here's the diff which results after running find . -name "*.dtd" -exec perl -p -i -e 's/(<!ENTITY.*)<!--.*-->/$1/' {} \; over hg clone http://hg.mozilla.org/releases/l10n-mozilla-2.0/ja 276 occurrences of a comment following an entity. Gerv
Comment 6•13 years ago
|
||
Here are all the affected strings, across the locales listed here: http://mxr.mozilla.org/mobile-browser/source/locales/maemo-locales Gerv
Assignee | ||
Comment 7•13 years ago
|
||
DTD comments are tricky to strip, so let's stop doing it for now. Properties files are line based comments and should be fine to strip using the existing code.
Assignee: nobody → mark.finkle
Attachment #520186 -
Flags: review?(blassey.bugs)
Reporter | ||
Comment 8•13 years ago
|
||
Comment on attachment 520186 [details] [diff] [review] patch to remove the comment stripping from DTD Looks good to me, feedback+ and thanks.
Attachment #520186 -
Flags: feedback+
Assignee | ||
Updated•13 years ago
|
tracking-fennec: ? → 2.0+
Updated•13 years ago
|
Attachment #520186 -
Flags: review?(blassey.bugs) → review+
Updated•13 years ago
|
Assignee | ||
Comment 9•13 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/a73d7944abef http://hg.mozilla.org/releases/mobile-2.0/rev/a73d7944abef http://hg.mozilla.org/releases/mobile-2.0/rev/915e4cd96592
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 10•13 years ago
|
||
verified FIXED on build: Mozilla/5.0 (Android; Linux armv7l; rv:2.1) Gecko/20110318 Firefox/4.0b13pre Fennec/4.0 ID:20110318114419
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•