Closed Bug 642931 Opened 13 years ago Closed 13 years ago

Mochitest in tests.zip wound up with contents of an unrelated test

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ted, Unassigned)

References

Details

I pushed to build-system and got a failure on Win32 Md1. I retriggered it, and it failed the same way. I downloaded the build + test package:
http://stage.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/build-system-win32-debug/1300408628/firefox-4.0b13pre.en-US.win32.zip
http://stage.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/build-system-win32-debug/1300408628/firefox-4.0b13pre.en-US.win32.tests.zip

and reproduced the failure on my machine. cat'ing the failing test (caps/tests/mochitest/test_bug292789.html) on my machine shows that it contains the contents of an unrelated a11y test:
http://mxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/treeupdate/test_recreation.html?force=1

Possibly related, the test is preprocessed:
http://mxr.mozilla.org/mozilla-central/source/caps/tests/mochitest/test_bug292789.html.in

From the build log:
e:/builds/moz2_slave/bld-system-w32-dbg/build/obj-firefox/config/nsinstall.exe -R "/e/builds/moz2_slave/bld-system-w32-dbg/build/caps/tests/mochitest/test_bug423375.html" "/e/builds/moz2_slave/bld-system-w32-dbg/build/caps/tests/mochitest/test_bug246699.html" "test_bug292789.html" "/e/builds/moz2_slave/bld-system-w32-dbg/build/caps/tests/mochitest/test_bug470804.html" ../../../_tests/testing/mochitest/tests/caps/tests/mochitest

This scares the crap out of me. Could this be a regression from the nsinstall_win symlink patch?
I suppose that's the likely candidate.  Can you link the build log?
Unless you've got some idea, can you back that patch out?
I'll think about it tonight and back it out tomorrow if I don't come up with anything.
catlee did some poking on the build slave:
<catlee> find dist/test-package-stage -type f -exec ls -li {} \; | grep 2072017
<catlee> 2072017 -rw-r--r-- 2 cltbld Administrators 4349 Mar 17 17:52 dist/test-package-stage/mochitest/a11y/accessible/treeupdate/test_recreation.html
<catlee> 2072017 -rw-r--r-- 2 cltbld Administrators 4349 Mar 17 17:52 dist/test-package-stage/mochitest/tests/caps/tests/mochitest/test_bug292789.html

So the files got screwed up during test package staging, and those two files wound up as hardlinks to the same file (the first number is the inode).

The only thing I can figure is that MSYS has a bug with windows hard links, since we just use tar to stage the test package:
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/Makefile.in#212
Blocks: 574183
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.