643027 - Files opened with helper app are deleted on exit but still appear in download manager

Status: RESOLVED DUPLICATE of bug 596370

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Search Google for "pdf".
2. Click a link to a open a PDF file in a PDF reader.
3. Quit or force-close Firefox.
4. Re-open Fennec.
5. Open the download manager.

Actual results: The file has been deleted, but it still appears in the download manager.  The "Open" button is disabled.  The "Delete" button is enabled and displays a "Delete file?" confirmation prompt, although there is no file to delete.

Expected results: The file is still present and appears in the download manager *OR* it has been deleted and does not appear in the download manager.

This is similar to desktop bug 191239, but I think Fennec should differ from desktop Firefox.  We already use a different design for the download manager, where removing a row from the download manager corresponds with deleting the file from disk.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

see bug 596370

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

removing the orphans makes a lot of sense. We can either mark the downloads that will be deleted on exit so they don't show up on the next run, or check for existence when building up the download manager.

The former sounds more robust to me.

Comment 3

[Wesley Johnston (:wesj)]

Just my opinion, but for Fennec.Next I think we should alter the way downloads are handled. URL's should be sent to the external-url-handler-service, and if there is a system app that can handle the url, we should cancel our download and send it there. Otherwise we download and save to the download folder. Apps should be url aware, and in some cases can stream data which makes for a better user experience than what we currently have.

In that case, the download manager needs to change. From the users perspective the flow of operations should be the same, but the DM is managing more of a download history than being a file browser (more like desktop), making it easy for users to get back to files they have previously looked at.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110422 Firefox/6.0a1 Fennec/6.0a1
Device: Thunderbolt
OS: Android 2.2

This also happens when the item is deleted in the helper app as well:
1. download an image in fennec
2. open the image file from the download section using gallery
3. delete the image using gallery
4. close the gallery and go back to fennec
5. since it's still listed, you can click on open and it opens up a black screen.

Comment 5

[Matt Brubeck (:mbrubeck)]

This bug will be fixed by bug 596370.  Wes, do you want to open follow-up bugs for any of the ideas in comment 3?