64306 - Need to provide stubs for NSPR functions used by lib/freebl/loader.c in lib/fortcrypt/swft/pkcs11.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Wan-Teh Chang]

On 32-bit Solaris and HP-UX, libfreebl now calls
PR_LoadLibraryWithFlags to load the DSO for the
CPU architecture.

We need to either provide stubs for these NSPR
library loading functions in lib/fortcrypt/swft/pkcs11/stub.c
or rewrite lib/freebl/loader.c to call dlopen or
shl_load directly.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

I would strongly prefer to see a real implementation of 
PR_LoadLibraryWithFLags (e.g. duplicated from NSPR) in the "stubs" 
functions than to stop using PR_LoadLibraryWithFlags.  

Also, note that loader.c also uses PR_FindSymbol.

Comment 2

[Wan-Teh Chang]

This bug is fixed as a by-product of fixing bug #66286.
lib/freebl/loader.c now calls dlopen or shl_load directly.

Comment 3

[Wan-Teh Chang]

Turns out this is not fixed.  Although freebl/loader.c
no longer uses PR_LoadLibraryWithFlags, PR_FindSymbol,
and PR_UnloadLibrary, it now needs PR_SetError and
PR_SetErrorText.

Comment 4

[Wan-Teh Chang]

Attachment: Proposed patch. Stubs for PR_SetError and PR_SetErrorText.

Comment 5

[Wan-Teh Chang]

Bob: could you review my patch?  Now lib/freebl/loader.c calls
PR_SetError and PR_SetErrorText (on 32-bit Solaris and HP-UX
only), so I added stubs for these two functions to
mozilla/security/nss/lib/fortcrypt/swfort/pkcs11/stub.c.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Patch looks good to me.

Comment 7

[Wan-Teh Chang]

I checked in my patch (id=23423) on the tip.