Need to provide stubs for NSPR functions used by lib/freebl/loader.c in lib/fortcrypt/swft/pkcs11.

RESOLVED FIXED in 3.2

Status

P3
normal
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: wtc, Assigned: wtc)

Tracking

Sun
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
On 32-bit Solaris and HP-UX, libfreebl now calls
PR_LoadLibraryWithFlags to load the DSO for the
CPU architecture.

We need to either provide stubs for these NSPR
library loading functions in lib/fortcrypt/swft/pkcs11/stub.c
or rewrite lib/freebl/loader.c to call dlopen or
shl_load directly.
(Assignee)

Updated

18 years ago
Priority: -- → P3
Target Milestone: --- → 3.2
I would strongly prefer to see a real implementation of 
PR_LoadLibraryWithFLags (e.g. duplicated from NSPR) in the "stubs" 
functions than to stop using PR_LoadLibraryWithFlags.  

Also, note that loader.c also uses PR_FindSymbol.
(Assignee)

Comment 2

18 years ago
This bug is fixed as a by-product of fixing bug #66286.
lib/freebl/loader.c now calls dlopen or shl_load directly.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

18 years ago
Turns out this is not fixed.  Although freebl/loader.c
no longer uses PR_LoadLibraryWithFlags, PR_FindSymbol,
and PR_UnloadLibrary, it now needs PR_SetError and
PR_SetErrorText.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

18 years ago
Created attachment 23423 [details] [diff] [review]
Proposed patch.  Stubs for PR_SetError and PR_SetErrorText.
(Assignee)

Comment 5

18 years ago
Bob: could you review my patch?  Now lib/freebl/loader.c calls
PR_SetError and PR_SetErrorText (on 32-bit Solaris and HP-UX
only), so I added stubs for these two functions to
mozilla/security/nss/lib/fortcrypt/swfort/pkcs11/stub.c.
Status: REOPENED → ASSIGNED
Patch looks good to me.
(Assignee)

Comment 7

18 years ago
I checked in my patch (id=23423) on the tip.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED
Summary: Need to provide stubs for PR_LoadLibraryWithFlags etc. in lib/fortcrypt/swft/pkcs11. → Need to provide stubs for NSPR functions used by lib/freebl/loader.c in lib/fortcrypt/swft/pkcs11.
You need to log in before you can comment on or make changes to this bug.