643110 - Facebook Badges page doesn't have RTL support

Status: VERIFIED FIXED

(Websites :: Facebook, defect)

Description

[Tomer Cohen :tomer]

Facebook Badges page looks bad in Hebrew, as it doesn't have dir=rtl for Right-To-Left locales. 

Steps to reproduce: 
a. Change your Facebook locale to Hebrew or Arabic http://www.facebook.com/editaccount.php?language
b. Go to the badges page.

Expected result: 
Texts should be right-aligned, using dir=rtl

Comment 1

[Staś Małolepszy :stas]

I was just about to file this bug.  Thanks Tomer!  I'll try to come up with a patch.

Comment 2

[William Reynolds [:williamr]]

Zach, let's try to get this fixed if Stas can have a patch ready by Sunday night. Thanks!

Comment 3

[Staś Małolepszy :stas]

I'll have a patch shortly.

Comment 4

[Matt Brandt [:mbrandt]]

Thanks all!

Comment 5

[Staś Małolepszy :stas]

Attachment: Patch (needs images)

Comment 6

[Staś Małolepszy :stas]

Attachment: Images (tar.gz)

Comment 7

[William Reynolds [:williamr]]

Zach, can you add this patch tonight or tomorrow morning? Thanks!

Comment 8

[Staś Małolepszy :stas]

Unless Zach has commit access to http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/stage/en-US/firefox/fb-badges/, we will also need Fred Wenzel to import Zach's changes into our SVN.

Comment 9

[William Reynolds [:williamr]]

(In reply to comment #8)
> Unless Zach has commit access to
> http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/stage/en-US/firefox/fb-badges/,
> we will also need Fred Wenzel to import Zach's changes into our SVN.

Zach has been committing to his personal SVN and then Fred has been pulling those changes into our SVN. It's not the best flow and for future projects, I suggest we improve the process.

Comment 10

[Matt Brandt [:mbrandt]]

Has this patch already been committed?

Comment 11

[Fred Wenzel [:wenzel]]

(In reply to comment #9)
> (In reply to comment #8)
> > Unless Zach has commit access to
> > http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/stage/en-US/firefox/fb-badges/,
> > we will also need Fred Wenzel to import Zach's changes into our SVN.
> 
> Zach has been committing to his personal SVN and then Fred has been pulling
> those changes into our SVN. It's not the best flow and for future projects, I
> suggest we improve the process.

!

Comment 12

[Fred Wenzel [:wenzel]]

trunk: r85849.
stage: r85852.

Comment 13

[Matt Brandt [:mbrandt]]

RTL support is looking good along with the patch to bug 643465.

Marking as QA verified.