IPC not building on Linux PPC

RESOLVED FIXED in mozilla6

Status

()

Core
IPC
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla6
PowerPC
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 520425 [details] [diff] [review]
Fix IPC for Linux PPC

Build ends with:
../../../ipc/chromium/src/build/build_config.h:64:2: error: #error Please add support for your architecture in build/build_config.h

This is because __ppc__ isn't defined by gcc on linux, while e.g. __powerpc__ is.
Attachment #520425 - Flags: review?(benjamin)
(Assignee)

Updated

7 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 1

7 years ago
Interestingly, I now get this:
ipc/chromium/src/base/data_pack.cc:96:3: error: size of array 'datapack_assumes_little_endian' is negative

I guess whenever the mac ppc support was added, this wasn't there...
(Assignee)

Comment 2

7 years ago
(In reply to comment #1)
> Interestingly, I now get this:
> ipc/chromium/src/base/data_pack.cc:96:3: error: size of array
> 'datapack_assumes_little_endian' is negative
> 
> I guess whenever the mac ppc support was added, this wasn't there...

Simpler: data_pack.cc is not used on mac.
(Assignee)

Comment 3

7 years ago
Created attachment 520465 [details] [diff] [review]
Fix IPC for Linux PPC

It turns out nothing uses DataPack, so we can just build without it.
Attachment #520425 - Attachment is obsolete: true
Attachment #520425 - Flags: review?(benjamin)
(Assignee)

Updated

7 years ago
Attachment #520465 - Flags: review?(benjamin)

Updated

7 years ago
Attachment #520465 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/b0df2e9b1489
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Duplicate of this bug: 587188
Duplicate of this bug: 579757
You need to log in before you can comment on or make changes to this bug.