Status
()
People
(Reporter: smaug, Assigned: mrbkap)
Tracking
(Blocks: 1 bug)
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 attachment, 1 obsolete attachment)
2.45 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
The method is called a lot (it is called when contextstack::Push is called), yet it does few QIs. Could we cache the return value?
(Assignee) | ||
Comment 1•8 years ago
|
||
Created attachment 525743 [details] [diff] [review] Proposed fix I'm about to send this through the try server.
(Assignee) | ||
Comment 2•8 years ago
|
||
That patch passed try.
Comment 3•8 years ago
|
||
Comment on attachment 525743 [details] [diff] [review] Proposed fix Minussing, bkap is going to attach a new patch that removes some code that we don't need anymore.
Attachment #525743 -
Flags: review?(peterv) → review-
(Assignee) | ||
Comment 4•8 years ago
|
||
Created attachment 533600 [details] [diff] [review] Better patch
Attachment #525743 -
Attachment is obsolete: true
Attachment #533600 -
Flags: review?(peterv)
Comment 5•8 years ago
|
||
Comment on attachment 533600 [details] [diff] [review] Better patch Review of attachment 533600 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsJSEnvironment.cpp @@ +2185,5 @@ > +#ifdef DEBUG > + { > + JSObject *inner = global; > + OBJ_TO_INNER_OBJECT(mContext, inner); > + NS_ASSERTION(inner == global, "unexpected innerization is possible"); I don't really understand this comment. @@ +2211,5 @@ > } else { > sgo = do_QueryInterface(priv); > } > > + return sgo; Seems like the removed comment would still be valid?
Attachment #533600 -
Flags: review?(peterv) → review+
(Assignee) | ||
Comment 6•8 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/3b1ffc6d282f
Whiteboard: fixed-in-tracemonkey
Comment 7•8 years ago
|
||
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/3b1ffc6d282f
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•