643393 - nsJSContext::GetGlobalObject is slow

Status: RESOLVED FIXED

Description

[Olli Pettay [:smaug] (PTO-ish Feb 16-23)]

The method is called a lot (it is called when contextstack::Push is called),
yet it does few QIs. Could we cache the return value?

Comment 1

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Created attachment 525743 [details] [diff] [review]
Proposed fix

I'm about to send this through the try server.

Comment 2

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

That patch passed try.

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 525743 [details] [diff] [review]
Proposed fix

Minussing, bkap is going to attach a new patch that removes some code that we don't need anymore.

Comment 4

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Created attachment 533600 [details] [diff] [review]
Better patch

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 533600 [details] [diff] [review]
Better patch

Review of attachment 533600 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +2185,5 @@
> +#ifdef DEBUG
> +  {
> +    JSObject *inner = global;
> +    OBJ_TO_INNER_OBJECT(mContext, inner);
> +    NS_ASSERTION(inner == global, "unexpected innerization is possible");

I don't really understand this comment.

@@ +2211,5 @@
>    } else {
>      sgo = do_QueryInterface(priv);
>    }
>  
> +  return sgo;

Seems like the removed comment would still be valid?

Comment 6

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

http://hg.mozilla.org/tracemonkey/rev/3b1ffc6d282f

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/3b1ffc6d282f