643411 - New default bug limit makes time summary results confusing

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 4.1.1+

I'm running bugzilla from bzr with latest updates.

Sometime in last 30 days this problem was introduced. I took exactly the same report now which I took last month and get different result.

When making report from database directly, like this:

SELECT product_id,name,realname,bug_when,a.bug_id,sum(added) as amount

	FROM `bugs`.`bugs_activity` as a

	inner join bugs.bugs as b on a.bug_id = b.bug_id and b.product_id in (2,17)

	inner join profiles as c on c.userid = a.who

	inner join products as d on d.id = b.product_id

	where fieldid = 43 and

		bug_when between '2011-01-21' and '2011-02-21' and

		bug_severity = 'Kasutajatugi'

	group by d.name,who,a.bug_id


 it matche's last month report from bugzilla.

So in database numbers are correct but bugzilla does not summarize them correctly.



Reproducible: Always

Comment 1

[[e-mail]]

I found that this behavior is related to new limit of 500 bugs when doung search list. I did not see it at first. When clicking link "show all bugs" and doing time summary then report comes out correctly.

So this is not a bug per se but mostly ui usability question. Time summary button should better notify user that not all bugs are taken into account.

(Or there should be time summary option on stright on the search screen so it should not have double date fields which make things overly complicated)

Comment 2

[Max Kanat-Alexander]

  Oh interesting, I hadn't thought about that. I will see what I can do to make this behave better. :-)

Comment 3

[Tiago Mello [:timello]]

Attachment: v1

Comment 4

[Max Kanat-Alexander]

Comment on attachment 567960 [details] [diff] [review]
v1

Review of attachment 567960 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/list/list.html.tmpl
@@ +184,5 @@
>          [% IF user.is_timetracker %]
>            <form method="post" action="summarize_time.cgi">
>              <input type="hidden" name="id" value="[% buglist_joined FILTER html %]">
> +            <input type="submit" id="timesummary" value="Time Summary"
> +              [% 'disabled="disabled"' IF disable_time_summary %]>

Instead of disabling the button, just have the note below say that the Time Summary will only include the bugs shown above, and to see a time summary of all bugs found by the search, they should show all the bugs.

Comment 5

[Frédéric Buclin]

(In reply to Max Kanat-Alexander from comment #4)
> Instead of disabling the button, just have the note below say that the Time
> Summary will only include the bugs shown above, and to see a time summary of
> all bugs found by the search, they should show all the bugs.

+1

Comment 6

[Tiago Mello [:timello]]

As you wish! :) I'll fix the patch, thanks for the review.

Comment 7

[Tiago Mello [:timello]]

Attachment: v2

Comment 8

[Max Kanat-Alexander]

Comment on attachment 572891 [details] [diff] [review]
v2

Review of attachment 572891 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/list/list.html.tmpl
@@ +188,5 @@
>            </form>
> +          [% IF time_summary_limited %]
> +            <small>
> +              Time Summary will only include the bugs shown above and in order to
> +              to see a time summary for all bugs found by the search you should 

Replace the "and" with a period and start a new sentence at "In".

Replace "you should" with "you can". Also, add a comma after "found by the search".

Comment 9

[Tiago Mello [:timello]]

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/                             
modified template/en/default/list/list.html.tmpl
Committed revision 7955.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/                           
modified template/en/default/list/list.html.tmpl
Committed revision 8004.