643446 - Buttons not aligned on the about:home page of french locale

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ayan Shah[:ashah]]

Mozilla/5.0 (Maemo; Linux arm7vl; rv:2.1) Gecko/20110318 Firefox/4.0b13pre Fennec/4.0

STR:
1. In the french locale, go to about:home
2. Go to the bottom of the page

Actual result:
The buttons are not placed correctly.(See screenshot)

Expected result:
They should be placed side by side.

Comment 1

[Ayan Shah[:ashah]]

Attachment: Screenshot

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

We have a value in the DTD file that localizers can use to adjust the width of the buttons based on the length of the strings:
http://mxr.mozilla.org/mobile-browser/source/locales/en-US/chrome/aboutHome.dtd#7

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

also occurs on android:
Mozilla/5.0 (Android; Linux armv71; rv:2.1) Gecko20110318 Firefox/4.0b13pre Fennec/4.0
Device: Droid 2 
OS: Android 2.2

I missed this in the test pass.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

CC'ing Cedric

Comment 5

[u162289]

(In reply to comment #4)
I change the size to 13em (we have 4 more characters in French). But I have no way to test it is OK.
http://hg.mozilla.org/l10n-central/fr/rev/25a3ab7704c4

Comment 6

[Martijn Wargers (dead)]

Yes, that seems to have fixed in the nightly Fennec build on the N900 (Maemo-GTK).
Can this bug be resolved->fixed now?

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #6)
> Yes, that seems to have fixed in the nightly Fennec build on the N900
> (Maemo-GTK).
> Can this bug be resolved->fixed now?

In  portrait mode?

Comment 8

[Martijn Wargers (dead)]

No, in portrait mode, it's still broken.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #8)
> No, in portrait mode, it's still broken.

I need to turn the size to 10em for having it working in portrait.
Cedric can you change for the french translation or do you want me to do my first l10n translation? :)

Comment 10

[u162289]

Done! Back to 10em --> http://hg.mozilla.org/l10n-central/fr/rev/7568f6e29278

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Thanks!

Comment 12

[Andreea Pod]

Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre)
Gecko/20110331 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: HTC Desire (Android 2.2)