Closed Bug 643488 Opened 13 years ago Closed 13 years ago

Port testToolbar/testBackForwardButtons.js

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gmealer, Assigned: gmealer)

References

(
URL
)

Details

(Whiteboard: [module-refactor]) 

Port testToolbar/testBackForwardButtons.js to Refactor project
Landed on master after making discussed naming changes (along with a quick bugfix in the test). Didn't think to collapse commits, so two of them:

https://github.com/geoelectric/mozmill-api-refactor/commit/b941691b4484cb6324802275fe89fc59860199f8

https://github.com/geoelectric/mozmill-api-refactor/commit/b941691b4484cb6324802275fe89fc59860199f8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You missed to change the isValid property of the element class as discussed yesterday. Looks like a small follow-up is necessary.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Gotcha, you gave the same changeset twice. The follow-up is:
https://github.com/geoelectric/mozmill-api-refactor/commit/35b4f5d34c70d10004e8adbafc45073017ed8b8c

So it is fixed indeed.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Oops, sorry about that. c/p fail on my part. :)
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.