64353 - Make mac buttons (and menulists) scalable (9 pieces)

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P1)

Description

[andreww]

Hyatt needs mac classic buttons to be scalable for XBL-ification of HTML
widgets. This is a tracker bug for that fix.

Comment 1

[andreww]

Accepting.

Comment 2

[Matthew T (active 1999-2002)]

--> Themes.

Are there equivalent bugs for popup menus, radio buttons, and checkboxes?

Comment 3

[andreww]

scalable radio buttons? Ask hyatt, he asked me to open this bug.

Comment 4

[andreww]

Adding depends on getting graphics...

Comment 5

[hangas]

Themes Triage Team nsbeta1+

Comment 6

[andreww]

setting milestone

Comment 7

[andreww]

I'm making great progress on this but it's looking more like it'll be in the .9
release. It's still my top priority however.

Comment 8

[andreww]

changing summary to include menulists, as they need 9 piece scaling too...

Comment 9

[andreww]

*** Bug 67385 has been marked as a duplicate of this bug. ***

Comment 10

[andreww]

*** Bug 65676 has been marked as a duplicate of this bug. ***

Comment 11

[andreww]

This is just about ready - I have local versions working and I'm incorporating
them into my tree today.

Comment 12

[andreww]

this bug is ready for review... I'll be adding the following files to the
repository:

mozilla/themes/classic/global/mac/button-active-left-btm.gif
mozilla/themes/classic/global/mac/button-active-left-mid.gif
mozilla/themes/classic/global/mac/button-active-left-top.gif
mozilla/themes/classic/global/mac/button-active-mid-btm.gif
mozilla/themes/classic/global/mac/button-active-mid-mid.gif
mozilla/themes/classic/global/mac/button-active-mid-top.gif
mozilla/themes/classic/global/mac/button-active-right-btm.gif
mozilla/themes/classic/global/mac/button-active-right-mid.gif
mozilla/themes/classic/global/mac/button-active-right-top.gif
mozilla/themes/classic/global/mac/button-def-active-left-btm.gif
mozilla/themes/classic/global/mac/button-def-active-left-mid.gif
mozilla/themes/classic/global/mac/button-def-active-left-top.gif
mozilla/themes/classic/global/mac/button-def-active-mid-btm.gif
mozilla/themes/classic/global/mac/button-def-active-mid-mid.gif
mozilla/themes/classic/global/mac/button-def-active-mid-top.gif
mozilla/themes/classic/global/mac/button-def-active-right-btm.gif
mozilla/themes/classic/global/mac/button-def-active-right-mid.gif
mozilla/themes/classic/global/mac/button-def-active-right-top.gif
mozilla/themes/classic/global/mac/button-def-dis-left-btm.gif
mozilla/themes/classic/global/mac/button-def-dis-left-mid.gif
mozilla/themes/classic/global/mac/button-def-dis-left-top.gif
mozilla/themes/classic/global/mac/button-def-dis-mid-btm.gif
mozilla/themes/classic/global/mac/button-def-dis-mid-top.gif
mozilla/themes/classic/global/mac/button-def-dis-middle.gif
mozilla/themes/classic/global/mac/button-def-dis-right-btm.gif
mozilla/themes/classic/global/mac/button-def-dis-right-mid.gif
mozilla/themes/classic/global/mac/button-def-dis-right-top.gif
mozilla/themes/classic/global/mac/button-def-left-btm.gif
mozilla/themes/classic/global/mac/button-def-left-mid.gif
mozilla/themes/classic/global/mac/button-def-left-top.gif
mozilla/themes/classic/global/mac/button-def-mid-btm.gif
mozilla/themes/classic/global/mac/button-def-mid-mid.gif
mozilla/themes/classic/global/mac/button-def-mid-top.gif
mozilla/themes/classic/global/mac/button-def-right-btm.gif
mozilla/themes/classic/global/mac/button-def-right-mid.gif
mozilla/themes/classic/global/mac/button-def-right-top.gif
mozilla/themes/classic/global/mac/button-dis-left-btm.gif
mozilla/themes/classic/global/mac/button-dis-left-mid.gif
mozilla/themes/classic/global/mac/button-dis-left-top.gif
mozilla/themes/classic/global/mac/button-dis-mid-btm.gif
mozilla/themes/classic/global/mac/button-dis-mid-mid.gif
mozilla/themes/classic/global/mac/button-dis-mid-top.gif
mozilla/themes/classic/global/mac/button-dis-right-btm.gif
mozilla/themes/classic/global/mac/button-dis-right-mid.gif
mozilla/themes/classic/global/mac/button-dis-right-top.gif
mozilla/themes/classic/global/mac/button-left-btm.gif
mozilla/themes/classic/global/mac/button-left-mid.gif
mozilla/themes/classic/global/mac/button-left-top.gif
mozilla/themes/classic/global/mac/button-mid-btm.gif
mozilla/themes/classic/global/mac/button-mid-mid.gif
mozilla/themes/classic/global/mac/button-mid-top.gif
mozilla/themes/classic/global/mac/button-right-btm.gif
mozilla/themes/classic/global/mac/button-right-mid.gif
mozilla/themes/classic/global/mac/button-right-top.gif
mozilla/themes/classic/global/mac/menulist-act-right-scalebit.gif
mozilla/themes/classic/global/mac/menulist-active-arrow.gif
mozilla/themes/classic/global/mac/menulist-active-left-btm.gif
mozilla/themes/classic/global/mac/menulist-active-left-mid.gif
mozilla/themes/classic/global/mac/menulist-active-left-top.gif
mozilla/themes/classic/global/mac/menulist-active-mid-btm.gif
mozilla/themes/classic/global/mac/menulist-active-mid-mid.gif
mozilla/themes/classic/global/mac/menulist-active-mid-top.gif
mozilla/themes/classic/global/mac/menulist-active-right-btm.gif
mozilla/themes/classic/global/mac/menulist-active-right-mid.gif
mozilla/themes/classic/global/mac/menulist-active-right-top.gif
mozilla/themes/classic/global/mac/menulist-arrow.gif
mozilla/themes/classic/global/mac/menulist-compact-arrow.gif
mozilla/themes/classic/global/mac/menulist-dis-arrow.gif
mozilla/themes/classic/global/mac/menulist-dis-left-btm.gif
mozilla/themes/classic/global/mac/menulist-dis-left-mid.gif
mozilla/themes/classic/global/mac/menulist-dis-left-top.gif
mozilla/themes/classic/global/mac/menulist-dis-mid-btm.gif
mozilla/themes/classic/global/mac/menulist-dis-mid-mid.gif
mozilla/themes/classic/global/mac/menulist-dis-mid-top.gif
mozilla/themes/classic/global/mac/menulist-dis-right-btm.gif
mozilla/themes/classic/global/mac/menulist-dis-right-mid.gif
mozilla/themes/classic/global/mac/menulist-dis-right-scalebit.gif
mozilla/themes/classic/global/mac/menulist-dis-right-top.gif
mozilla/themes/classic/global/mac/menulist-left-btm.gif
mozilla/themes/classic/global/mac/menulist-left-mid.gif
mozilla/themes/classic/global/mac/menulist-left-top.gif
mozilla/themes/classic/global/mac/menulist-mid-btm.gif
mozilla/themes/classic/global/mac/menulist-mid-mid.gif
mozilla/themes/classic/global/mac/menulist-mid-top.gif
mozilla/themes/classic/global/mac/menulist-right-btm.gif
mozilla/themes/classic/global/mac/menulist-right-mid.gif
mozilla/themes/classic/global/mac/menulist-right-scalebit.gif
mozilla/themes/classic/global/mac/menulist-right-top.gif

----

Now adding attachments for the diffs

Comment 13

[andreww]

Attachment: all diffs for this bug - various files

Comment 14

[timeless]

>     background                        : 
url("chrome://global/skin/button-left-top.gif") no-repeat;
>     height          : 4px;
is there a reason the two :'s don't align?

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

r=[e-mail]

Comment 16

[Joe Hewitt (gone)]

sr=hewitt

Comment 17

[andreww]

checked in yesterday - fixed both buttons and menulists.
QA - if you need a test page for this, let me know .

Comment 18

[Matthew T (active 1999-2002)]

Small buttons (those which use Geneva 10 or similar for their text) now appear to 
be one or two pixels too short. Was that caused by this bug?

Comment 19

[andreww]

Attachment: this is a test xul file for buttons - shows that they can scale

Comment 20

[andreww]

Attachment: zip containing two tests - one for buttons and one for menulists.

Comment 21

[andreww]

pmac: I added an attachment "zip containing...." which is a zip file containing
xul files which you can open in the browser and test the scaling of menulists
and buttons.  Unzip the whole thing to some directory and open test.xul, and
then menulist.xul 

You can see the differences by going to a prev-build and see how it's different.

Comment 22

[Patty Mac]

Thanks very much, Andrew. I will verify it.

Comment 23

[Patty Mac]

Marking verified on Mac (2001-02-31-04-Mtrunk).