643695 - new dependency: libxul.so requires libdbus-glib-1.so.2

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[jari.bakken]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_6) AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.697.0 Safari/534.24
Build Identifier: ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/4.0rc2/linux-x86_64/en-US/firefox-4.0rc2.tar.bz2   

I'm trying to run Firefox 4 RC 2 on a minimal install of Debian Squeeze. It looks like a new/undocumented dependency was introduced some time since beta 10:

  finn@qa1:/iad/qa/firefox-4.0rc2$ DISPLAY=:2 ./firefox
  ./firefox-bin: error while loading shared libraries: libdbus-glib-1.so.2: cannot open shared object file: No such file or directory

I found this old bug report which seems to describe the exact same issue:

  https://bugzilla.mozilla.org/show_bug.cgi?id=448375

Some further investigation confirms that it's a dependency of libxul.so:

 finn@qa1:/iad/qa/firefox-4.0rc2$ ldd libxul.so 2>/dev/null | grep libdbus-glib
               libdbus-glib-1.so.2 => not found

And then a huge hack confirms that it's not a "real" dependency (note I'm symlinking libdbus, not libdbus-glib):

  finn@qa1:/iad/qa/firefox-4.0rc2$ ln -s /lib/libdbus-1.so.3.4.0 libdbus-glib-1.so.2
  finn@qa1:/iad/qa/firefox-4.0rc2$ DISPLAY=:2 ./firefox
  Xlib:  extension "RANDR" missing on display ":2.0".
  ^C
  finn@qa1:/iad/qa/firefox-4.0rc2$

i.e. it at least launches successfully with the "fake" lib in place.

Reproducible: Always

Steps to Reproduce:
1. Run RC2 on a machine without libdbus-glib 

Actual Results:  
  ./firefox-bin: error while loading shared libraries: libdbus-glib-1.so.2: cannot open shared object file: No such file or directory


Expected Results:  
Firefox launches successfully.

Comment 1

[(not currently active) Ted Mielczarek]

Do we care anymore? I have no idea.

Comment 2

[Mike Hommey [:glandium]]

Mmmmm I thought I had fixed this a while ago.

Comment 3

[Mike Hommey [:glandium]]

Err, yes I had, in bug 448375, which jari linked.

Comment 4

[Mike Hommey [:glandium]]

Broken by bug 562725

Comment 5

[Mike Hommey [:glandium]]

Attachment: Don't depend on libdbus-glib when not necessary

Fix should be as easy as this. This might be something we want for 4.0.1

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 520895 [details] [diff] [review]
Don't depend on libdbus-glib when not necessary

I agree with glandium, we should consider taking this in 4.0.1.

Comment 7

[(not currently active) Ted Mielczarek]

If this is something you want to keep fixed, you should figure out a unit test for it. (Even something in "make check" using ldd would probably do it.)

Comment 8

[Mike Hommey [:glandium]]

On the long run, I think we should just use -Wl,--as-needed, which would get rid of it even if it is in the build rules.

Comment 9

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/208e4e19cc1a

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I backed this out because it was part of a push that caused bug 644790, and out of an abundance of caution (and a desire to get bug 644790 working again before we get to sleep), I backed the whole push out.  (It was two tiny patches, of which this was one, and then the likely culprit in a series of five patches that may have had to be backed out all together.)

http://hg.mozilla.org/mozilla-central/rev/e11c2f95f781

Comment 11

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/a69e803673e7

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 520895 [details] [diff] [review]
Don't depend on libdbus-glib when not necessary

Approved for the mozilla2.0 repository, a=dveditz for release-drivers

Comment 13

[LegNeato]

Transplanted from mozilla-central onto releases/mozilla2.0:

  http://hg.mozilla.org/releases/mozilla-2.0/rev/967fd562304a

Comment 14

[Emin Mastizada]

I'm testing new translation in aurora, and my OS is Ubuntu Linux x64. I'm getting this error for last few releases:

$ ./firefox -p translation -no-remote -Wl
XPCOMGlueLoad error for file /path/to/unzip/firefox/libxul.so:
libdbus-glib-1.so.2: cannot open shared object file: No such file or directory
Couldn't load XPCOM.

But x32 version works good. Do anybody know why in x64 system x64 version of firefox not works?