Implement better dropmarker icon for menu buttons and toolbar buttons

ASSIGNED
Assigned to

Status

()

Toolkit
Themes
ASSIGNED
7 years ago
7 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Created attachment 520909 [details] [diff] [review]
patch

Menu buttons and toolbar buttons are using arrow-dn.gif in Winstripe. This is black with a gray outline in order to be visible on different backgrounds. This is a poor compromise, though. On Windows, the arrow is supposed to use the same color as the text (i.e. completely black, completely white, whatever). The Marlett font should be used to that end, but Gecko doesn't allow using that (in order to prevent platform-specific web pages: bug 33127). Unfortunately, all arrows defined in Unicode have different shapes from Marlett's, so I'm using using U+25BC, the "black down-pointing triangle", and scaling it with -moz-transform. The result is pretty close to native.
Attachment #520909 - Flags: review?(neil)
(Assignee)

Updated

7 years ago
OS: Windows XP → Windows 7

Comment 1

7 years ago
(In reply to comment #0)
> Menu buttons and toolbar buttons are using arrow-dn.gif in Winstripe.
In which OS theme? I checked XP Luna and Server 2008 [Classic] and they both use native drawing. I think OS/2 might use it though...
(Assignee)

Comment 2

7 years ago
XP Luna, Classic as well as Aero glass on Win7. Looking at dropmarker.css, button.css and toolbarbutton.css, I don't see where native drawing should come from.

Comment 3

7 years ago
(In reply to comment #2)
> XP Luna, Classic as well as Aero glass on Win7. Looking at dropmarker.css,
> button.css and toolbarbutton.css, I don't see where native drawing should come
> from.
http://mxr.mozilla.org/mozilla-central/search?string=-moz-appearance%3A+menulist-button%3B says dropmarker.css, but it's line 2, so maybe you skipped it by mistake ;-)
(Assignee)

Comment 4

7 years ago
button.css and toolbarbutton.css reset that appearance (intentionally, because menulist-button doesn't fit here).

Comment 5

7 years ago
Sorry, I got my dropmarkers mixed up.

Comment 6

7 years ago
Created attachment 522783 [details]
XP with default settings

So, this is what it looks like on XP by default...

I also noticed the following spam in the Error Console:

Warning: XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block.
Source File: chrome://inspector/content/inspector.xul
Line: 0
(Assignee)

Comment 7

7 years ago
(In reply to comment #6)
> Created attachment 522783 [details]
> XP with default settings
> 
> So, this is what it looks like on XP by default...

After twiddling with the font-size and -moz-transform factor, I thought this didn't happen anymore. I guess I messed something up, or maybe this happens only when the dropmarker is rendered in certain positions...

> I also noticed the following spam in the Error Console:
> 
> Warning: XUL box for _moz_generated_content_before element contained an inline
> #text child, forcing all its children to be wrapped in a block.
> Source File: chrome://inspector/content/inspector.xul
> Line: 0

I'll see what I can do about that.
(Assignee)

Updated

7 years ago
Attachment #520909 - Flags: review?(neil)
You need to log in before you can comment on or make changes to this bug.