Last Comment Bug 643779 - Error: selected processor does not support ARM mode `bkpt #0' in nsDebugImpl.cpp on armv4t
: Error: selected processor does not support ARM mode `bkpt #0' in nsDebugImpl....
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: ARM Linux
: -- normal (vote)
: mozilla7
Assigned To: Mike Hommey [:glandium]
:
: Nathan Froyd [:froydnj]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-22 09:20 PDT by Mike Hommey [:glandium]
Modified: 2011-07-02 02:38 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
BKPT opcode is only supported on armv5+ (506 bytes, patch)
2011-03-22 09:20 PDT, Mike Hommey [:glandium]
doug.turner: review+
Details | Diff | Splinter Review
BKPT opcode is only supported on armv5+ (708 bytes, patch)
2011-05-16 11:25 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Allow to build nsDebugImpl.cpp on ARMv4T (996 bytes, patch)
2011-06-30 08:22 PDT, Mike Hommey [:glandium]
doug.turner: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2011-03-22 09:20:17 PDT
Created attachment 520935 [details] [diff] [review]
BKPT opcode is only supported on armv5+

I know you don't support armv4t, but the fix is trivial enough.
Comment 1 Doug Turner (:dougt) 2011-04-13 13:31:44 PDT
is __ARM_ARCH__ < 4 going to run very well?
Comment 2 Mike Hommey [:glandium] 2011-04-13 14:39:10 PDT
(In reply to comment #1)
> is __ARM_ARCH__ < 4 going to run very well?

I doubt it, considering it was already painful to get armv4t working.
Comment 3 Doug Turner (:dougt) 2011-04-13 22:35:37 PDT
I do not think we want this fix.
Comment 4 Mike Hommey [:glandium] 2011-04-13 23:33:22 PDT
(In reply to comment #3)
> I do not think we want this fix.

Why is that? (I'll still have to apply it on debian arm builds)
Comment 5 Doug Turner (:dougt) 2011-05-16 11:05:10 PDT
The device that mike cares about is very old, but still runs minefield okay.
Comment 6 Mike Hommey [:glandium] 2011-05-16 11:25:51 PDT
Created attachment 532692 [details] [diff] [review]
BKPT opcode is only supported on armv5+

The previous version wasn't actually working. I changed to this patch a few weeks ago.
Comment 7 Doug Turner (:dougt) 2011-05-19 10:33:48 PDT
Comment on attachment 532692 [details] [diff] [review]
BKPT opcode is only supported on armv5+

have you tested this on > armv5?
Comment 8 Mike Hommey [:glandium] 2011-05-19 10:45:48 PDT
(In reply to comment #7)
> Comment on attachment 532692 [details] [diff] [review] [review]
> BKPT opcode is only supported on armv5+
> 
> have you tested this on > armv5?

It could be safer to add an #ifdef __ARM_ARCH_4T__
Comment 9 Doug Turner (:dougt) 2011-05-20 15:44:14 PDT
if __ARM_ARCH_4T__ is defined for you, then sure!
Comment 10 Mike Hommey [:glandium] 2011-06-30 08:22:46 PDT
Created attachment 543135 [details] [diff] [review]
Allow to build nsDebugImpl.cpp on ARMv4T
Comment 11 Doug Turner (:dougt) 2011-06-30 09:55:45 PDT
Comment on attachment 543135 [details] [diff] [review]
Allow to build nsDebugImpl.cpp on ARMv4T

looks good.  simple comment for extra points.
Comment 13 Marco Bonardo [::mak] 2011-07-02 02:38:53 PDT
http://hg.mozilla.org/mozilla-central/rev/cbb285709139

Note You need to log in before you can comment on or make changes to this bug.