Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Error: selected processor does not support ARM mode `bkpt #0' in nsDebugImpl.cpp on armv4t

RESOLVED FIXED in mozilla7

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla7
ARM
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 520935 [details] [diff] [review]
BKPT opcode is only supported on armv5+

I know you don't support armv4t, but the fix is trivial enough.
Attachment #520935 - Flags: review?(benjamin)
Attachment #520935 - Flags: review?(benjamin) → review?(doug.turner)

Comment 1

6 years ago
is __ARM_ARCH__ < 4 going to run very well?
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> is __ARM_ARCH__ < 4 going to run very well?

I doubt it, considering it was already painful to get armv4t working.

Comment 3

6 years ago
I do not think we want this fix.
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> I do not think we want this fix.

Why is that? (I'll still have to apply it on debian arm builds)

Updated

6 years ago
Attachment #520935 - Flags: review?(doug.turner) → review+

Comment 5

6 years ago
The device that mike cares about is very old, but still runs minefield okay.
(Assignee)

Comment 6

6 years ago
Created attachment 532692 [details] [diff] [review]
BKPT opcode is only supported on armv5+

The previous version wasn't actually working. I changed to this patch a few weeks ago.
Assignee: nobody → mh+mozilla
Attachment #520935 - Attachment is obsolete: true
Attachment #532692 - Flags: review?(doug.turner)

Comment 7

6 years ago
Comment on attachment 532692 [details] [diff] [review]
BKPT opcode is only supported on armv5+

have you tested this on > armv5?
(Assignee)

Comment 8

6 years ago
(In reply to comment #7)
> Comment on attachment 532692 [details] [diff] [review] [review]
> BKPT opcode is only supported on armv5+
> 
> have you tested this on > armv5?

It could be safer to add an #ifdef __ARM_ARCH_4T__

Comment 9

6 years ago
if __ARM_ARCH_4T__ is defined for you, then sure!

Updated

6 years ago
Attachment #532692 - Flags: review?(doug.turner)
(Assignee)

Updated

6 years ago
Attachment #532692 - Attachment filename: diff → bug643779
(Assignee)

Comment 10

6 years ago
Created attachment 543135 [details] [diff] [review]
Allow to build nsDebugImpl.cpp on ARMv4T
Attachment #543135 - Flags: review?(doug.turner)
(Assignee)

Updated

6 years ago
Attachment #532692 - Attachment is obsolete: true
Comment on attachment 543135 [details] [diff] [review]
Allow to build nsDebugImpl.cpp on ARMv4T

looks good.  simple comment for extra points.
Attachment #543135 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 12

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/cbb285709139
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/cbb285709139
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.