643840 - Crash [@ WrappedNativeSuspecter ]

Status: RESOLVED WORKSFORME

(Core :: XPConnect, defect)

Description

[Marcia Knous [:marcia]]

Seen while reviewing crash reports. http://tinyurl.com/4h9qs5j links to the current crashes. Currently #126 in the 4.0 stats.

https://crash-stats.mozilla.com/report/index/13c15779-6c84-4536-88ff-c16402110322

Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	WrappedNativeSuspecter 	js/src/xpconnect/src/xpcwrappednativescope.cpp:405
1 	mozjs.dll 	JS_DHashTableEnumerate 	js/src/jsdhash.cpp:743
2 	xul.dll 	XPCWrappedNativeScope::SuspectAllWrappers 	js/src/xpconnect/src/xpcwrappednativescope.cpp:424
3 	xul.dll 	XPCJSRuntime::AddXPConnectRoots 	js/src/xpconnect/src/xpcjsruntime.cpp:566
4 	xul.dll 	nsXPConnect::BeginCycleCollection 	js/src/xpconnect/src/nsXPConnect.cpp:505
5 	xul.dll 	nsCycleCollector::BeginCollection 	xpcom/base/nsCycleCollector.cpp:2582

Comment 1

[Marcia Knous [:marcia]]

Windows version showing up in Trunk Crash stats: http://tinyurl.com/42fgluz

Comment 2

[Wayne Mery (:wsmwk)]

bp-9aa43e5b-4cc3-4e46-a07c-dc96c2110629 TB5.0
bp-1fe60826-a747-48b7-9c4d-b54532110629 TB3.1.11

Comment 3

[Andrew McCreight [:mccr8]]

I see a half dozen of these crashes on Nightly right now, looking sort of like a null deref on this line, which is fairly odd:

348    if (wrapper->HasExternalReference()) {

Crashes trying to read a few different small integers.  It might be worth looking into why Native2WrappedNativeMap can have a null value.  If I'm reading the results correctly, it looks like it may have gone up 50 places in the last few days (only to about 43 so not a huge crash), so I wonder if it could be related to any of the XPC things I've landed lately.

Comment 4

[Andrew McCreight [:mccr8]]

Here's an example:
https://crash-stats.mozilla.com/report/index/44f8a6da-5284-47de-a8ef-91f1e2120805

Comment 5

[NoOp]

Another:
SeaMonkey 2.13.2:
https://crash-stats.mozilla.com/report/index/bp-e2ca713f-daf2-430e-ab1b-364092121103

Comment 6

[NoOp]

And two more SeaMonkey 2.13.1:
https://crash-stats.mozilla.com/report/index/bp-b8427853-d9ac-46e7-86b2-6772f2121019
https://crash-stats.mozilla.com/report/index/bp-98f963de-aa9f-48ec-8489-04af92121016

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm marking this bug as WORKSFORME as bug crashlog signature didn't appear from a long time (over half year) in Firefox (except some obsolete Fx <39).